From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luca Tettamanti Subject: Re: [PATCH 1/2] RFC: ACPI: Interface for ACPI drivers to place quirk code which gets executed early Date: Mon, 2 Feb 2009 21:22:46 +0100 Message-ID: <20090202202246.GA9023@dreamland.darkstar.lan> References: <20090125210520.GA12963@dreamland.darkstar.lan> <20090202101103.1208c035@hyperion.delvare> <68676e00902020338o7326ff7dx4efadf94ed534acf@mail.gmail.com> <200902021822.11906.trenn@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from fg-out-1718.google.com ([72.14.220.153]:56037 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753087AbZBBUWq (ORCPT ); Mon, 2 Feb 2009 15:22:46 -0500 Content-Disposition: inline In-Reply-To: <200902021822.11906.trenn@suse.de> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Thomas Renninger Cc: Jean Delvare , Hans de Goede , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Len Brown Il Mon, Feb 02, 2009 at 06:22:10PM +0100, Thomas Renninger ha scritto: > These two patches are tested on a ASUS machine and worked as expected, > but probably may still need some cleanup. I'd keep the DMI+HID approach since it's more flexible: - (AFAICS) Thinkpads have different methods for hwmon depending on the model and no fixed HID - With DMI it would be possible to include ASUS motherboards (ATK w/ hwmon) but exclude ASUS laptops (ATK w/o hwmon). > diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c > index c54d7b6..1c25747 100644 > --- a/drivers/acpi/scan.c > +++ b/drivers/acpi/scan.c > @@ -10,6 +10,7 @@ > #include > > #include > +#include "acpi.h" > > #define _COMPONENT ACPI_BUS_COMPONENT > ACPI_MODULE_NAME("scan"); > @@ -1562,6 +1563,8 @@ static int __init acpi_scan_init(void) > > if (result) > acpi_device_unregister(acpi_root, ACPI_BUS_REMOVAL_NORMAL); > + else > + acpi_device_quirks(); Hum, it's not immediatly clear why you put that call in the else branch. Maybe put: if (!result) acpi_device_quirks(); before the cleanup? Luca -- "La mia teoria scientifica preferita e` quella secondo la quale gli anelli di Saturno sarebbero interamente composti dai bagagli andati persi nei viaggi aerei." -- Mark Russel