From: Alex Chiang <achiang@hp.com>
To: Andrew Patterson <andrew.patterson@hp.com>
Cc: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
linux acpi <linux-acpi@vger.kernel.org>,
Matthew Wilcox <matthew@wil.cx>
Subject: Re: [PATCH] PCI/ACPI: move _OSC code to pci_root.c
Date: Tue, 3 Feb 2009 17:33:20 -0700 [thread overview]
Message-ID: <20090204003320.GC23309@ldl.fc.hp.com> (raw)
In-Reply-To: <1233703252.14203.161.camel@localhost>
* Andrew Patterson <andrew.patterson@hp.com>:
> On Tue, 2009-02-03 at 14:57 +0900, Kenji Kaneshige wrote:
> > + /* Need to ignore the bit0 in result code */
> > + errors = *((u32 *)out_obj->buffer.pointer) & ~(1 << 0);
> > + if (errors) {
> > + if (errors & OSC_REQUEST_ERROR)
> > + printk(KERN_DEBUG "_OSC request fails\n");
> > + if (errors & OSC_INVALID_UUID_ERROR)
> > + printk(KERN_DEBUG "_OSC invalid UUID\n");
> > + if (errors & OSC_INVALID_REVISION_ERROR)
> > + printk(KERN_DEBUG "_OSC invalid revision\n");
> > + if (errors & OSC_CAPABILITIES_MASK_ERROR) {
> > + if (capbuf[OSC_QUERY_TYPE] & OSC_QUERY_ENABLE)
> > + goto out_success;
> > + printk(KERN_DEBUG "_OSC FW not grant req. control\n");
>
> Can this be worded better? Perhaps "Firmware would not grant requested
> _OSC control"? I know this is not your code, but maybe we can fix this
> now.
Trying not to bike shed, but if you're going to change the
wording, I'd prefer to see "Firmware did not..." vs "Firmware
would not..."
Thanks.
/ac
next prev parent reply other threads:[~2009-02-04 0:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-03 5:57 [PATCH] PCI/ACPI: move _OSC code to pci_root.c Kenji Kaneshige
2009-02-03 23:20 ` Andrew Patterson
2009-02-04 0:33 ` Alex Chiang [this message]
2009-02-04 6:20 ` Kenji Kaneshige
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090204003320.GC23309@ldl.fc.hp.com \
--to=achiang@hp.com \
--cc=andrew.patterson@hp.com \
--cc=jbarnes@virtuousgeek.org \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox