From: Frans Pop <elendil@planet.nl>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
linux-acpi@vger.kernel.org, linux-pm@lists.linux-foundation.org,
len.brown@intel.com, shaohuhua.li@intel.com,
kristen.c.accardi@intel.com, frank@f-seidel.de, fseidel@suse.de
Subject: Re: [PATCH] ACPI: add missing KERN_* constants to printks
Date: Wed, 4 Feb 2009 16:28:00 +0100 [thread overview]
Message-ID: <200902041628.03675.elendil@planet.nl> (raw)
In-Reply-To: <4989A784.3030604@suse.de>
Frank Seidel wrote:
> +++ b/drivers/acpi/pci_link.c
> @@ -593,7 +593,7 @@ static int acpi_pci_link_allocate(struct
> return -ENODEV;
> } else {
> acpi_irq_penalty[link->irq.active] += PIRQ_PENALTY_PCI_USING;
> - printk(PREFIX "%s [%s] enabled at IRQ %d\n",
> + printk(KERN_WARNING PREFIX "%s [%s] enabled at IRQ %d\n",
> acpi_device_name(link->device),
> acpi_device_bid(link->device), link->irq.active);
> }
> @@ -751,21 +751,21 @@ static int acpi_pci_link_add(struct acpi
> acpi_device_bid(device));
> for (i = 0; i < link->irq.possible_count; i++) {
> if (link->irq.active == link->irq.possible[i]) {
> - printk(" *%d", link->irq.possible[i]);
> + printk(KERN_INFO " *%d", link->irq.possible[i]);
> found = 1;
> } else
> - printk(" %d", link->irq.possible[i]);
> + printk(KERN_INFO " %d", link->irq.possible[i]);
> }
>
> - printk(")");
> + printk(KERN_INFO ")");
>
> if (!found)
> - printk(" *%d", link->irq.active);
> + printk(KERN_INFO " *%d", link->irq.active);
>
This patch looks broken to me, at least for some of your changes.
For example, in the bit quoted above all printks together make up
*one single* message, which means that only the _first_ of the
printks should have the KERN_* prefix. printks that are continuations
should not have the prefix.
Cheers,
FJP
next prev parent reply other threads:[~2009-02-04 15:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-04 14:34 [PATCH] ACPI: add missing KERN_* constants to printks Frank Seidel
2009-02-04 15:28 ` Frans Pop [this message]
2009-02-04 15:31 ` Frank Seidel
2009-02-04 15:44 ` Geert Uytterhoeven
2009-02-04 15:48 ` Frank Seidel
2009-02-04 16:12 ` Frans Pop
2009-02-04 16:48 ` Geert Uytterhoeven
2009-02-04 16:03 ` [PATCHv2] " Frank Seidel
2009-02-07 5:38 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902041628.03675.elendil@planet.nl \
--to=elendil@planet.nl \
--cc=akpm@linux-foundation.org \
--cc=frank@f-seidel.de \
--cc=fseidel@suse.de \
--cc=kristen.c.accardi@intel.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=shaohuhua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox