From: Carlos Corbacho <carlos@strangeworlds.co.uk>
To: linux-acpi@vger.kernel.org
Subject: [PATCH 1/4] acer-wmi: double free in acer_rfkill_exit()
Date: Sat, 14 Feb 2009 09:53:48 +0000 [thread overview]
Message-ID: <20090214095348.18550.46246.stgit@localhost> (raw)
In-Reply-To: <20090214095342.18550.24339.stgit@localhost>
From: Dan Carpenter <error27@gmail.com>
This is acer_rfkill_exit() from drivers/platform/x86/acer-wmi.c.
The code frees wireless_rfkill->data again instead of
bluetooth_rfkill->data.
This was found using a code checker (http://repo.or.cz/w/smatch.git/).
Compile tested only, sorry.
regards,
dan carpenter
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Carlos Corbacho <carlos@strangeworlds.co.uk>
--- orig/drivers/platform/x86/acer-wmi.c 2009-02-03 08:06:54.000000000 +0300
+++ devel/drivers/platform/x86/acer-wmi.c 2009-02-03 08:07:16.000000000 +0300
@@ -1026,7 +1026,7 @@
kfree(wireless_rfkill->data);
rfkill_unregister(wireless_rfkill);
if (has_cap(ACER_CAP_BLUETOOTH)) {
- kfree(wireless_rfkill->data);
+ kfree(bluetooth_rfkill->data);
rfkill_unregister(bluetooth_rfkill);
}
return;
---
0 files changed, 0 insertions(+), 0 deletions(-)
next prev parent reply other threads:[~2009-02-14 10:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-14 9:53 [PATCH 0/4] WMI patches for 2.6.29-rc5 Carlos Corbacho
2009-02-14 9:53 ` Carlos Corbacho [this message]
2009-02-14 9:53 ` [PATCH 2/4] ACPI: WMI: Unmark as 'experimental' Carlos Corbacho
2009-02-14 9:53 ` [PATCH 3/4] acer-wmi: " Carlos Corbacho
2009-02-14 9:54 ` [PATCH 4/4] acer-wmi: Fix acpi video detection Carlos Corbacho
2009-03-16 2:32 ` [PATCH 0/4] WMI patches for 2.6.29-rc5 Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090214095348.18550.46246.stgit@localhost \
--to=carlos@strangeworlds.co.uk \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox