* [PATCH] ACPI: PCI: use generic pci_swizzle_interrupt_pin()
@ 2009-02-17 20:49 Bjorn Helgaas
2009-03-12 22:51 ` Bjorn Helgaas
2009-03-17 5:56 ` Len Brown
0 siblings, 2 replies; 3+ messages in thread
From: Bjorn Helgaas @ 2009-02-17 20:49 UTC (permalink / raw)
To: Len Brown; +Cc: linux-acpi
Use the generic pci_swizzle_interrupt_pin() instead of ACPI-specific code.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
---
drivers/acpi/pci_irq.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/acpi/pci_irq.c b/drivers/acpi/pci_irq.c
index 891bdf6..be6b909 100644
--- a/drivers/acpi/pci_irq.c
+++ b/drivers/acpi/pci_irq.c
@@ -319,7 +319,7 @@ static struct acpi_prt_entry *acpi_pci_irq_lookup(struct pci_dev *dev, int pin)
*/
bridge = dev->bus->self;
while (bridge) {
- pin = (((pin - 1) + PCI_SLOT(dev->devfn)) % 4) + 1;
+ pin = pci_swizzle_interrupt_pin(dev, pin);
if ((bridge->class >> 8) == PCI_CLASS_BRIDGE_CARDBUS) {
/* PC card has the same IRQ as its cardbridge */
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ACPI: PCI: use generic pci_swizzle_interrupt_pin()
2009-02-17 20:49 [PATCH] ACPI: PCI: use generic pci_swizzle_interrupt_pin() Bjorn Helgaas
@ 2009-03-12 22:51 ` Bjorn Helgaas
2009-03-17 5:56 ` Len Brown
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Helgaas @ 2009-03-12 22:51 UTC (permalink / raw)
To: Len Brown; +Cc: linux-acpi
On Tuesday 17 February 2009 1:49:10 pm Bjorn Helgaas wrote:
> Use the generic pci_swizzle_interrupt_pin() instead of ACPI-specific code.
Did you have a reaction to this? If you did, I missed it.
> Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
> ---
> drivers/acpi/pci_irq.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/acpi/pci_irq.c b/drivers/acpi/pci_irq.c
> index 891bdf6..be6b909 100644
> --- a/drivers/acpi/pci_irq.c
> +++ b/drivers/acpi/pci_irq.c
> @@ -319,7 +319,7 @@ static struct acpi_prt_entry
> *acpi_pci_irq_lookup(struct pci_dev *dev, int pin) */
> bridge = dev->bus->self;
> while (bridge) {
> - pin = (((pin - 1) + PCI_SLOT(dev->devfn)) % 4) + 1;
> + pin = pci_swizzle_interrupt_pin(dev, pin);
>
> if ((bridge->class >> 8) == PCI_CLASS_BRIDGE_CARDBUS) {
> /* PC card has the same IRQ as its cardbridge */
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ACPI: PCI: use generic pci_swizzle_interrupt_pin()
2009-02-17 20:49 [PATCH] ACPI: PCI: use generic pci_swizzle_interrupt_pin() Bjorn Helgaas
2009-03-12 22:51 ` Bjorn Helgaas
@ 2009-03-17 5:56 ` Len Brown
1 sibling, 0 replies; 3+ messages in thread
From: Len Brown @ 2009-03-17 5:56 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: linux-acpi
applied
--
Len Brown, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-03-17 5:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-17 20:49 [PATCH] ACPI: PCI: use generic pci_swizzle_interrupt_pin() Bjorn Helgaas
2009-03-12 22:51 ` Bjorn Helgaas
2009-03-17 5:56 ` Len Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox