Re: [PATCH 1/4] eeepc-laptop: Fix Kconfig

[Andrew Morton <akpm@linux-foundation.org>]

On Wed, 25 Feb 2009 08:57:36 +0100 Corentin Chary <corentin.chary@gmail.com> wrote:

> On Tue, Feb 24, 2009 at 11:44 PM, Andrew Morton
> <akpm@linux-foundation.org> wrote:
> > On Sun, 15 Feb 2009 19:30:18 +0100
> > Corentin Chary <corentincj@iksaif.net> wrote:
> >
> >> Add a "select INPUT" to Kconfig now that eeepc-laptop
> >> is using the input layer.
> >>
> >> Signed-off-by: Corentin Chary <corentincj@iksaif.net>
> >> ---
> >> __drivers/platform/x86/Kconfig | __ __1 +
> >> __1 files changed, 1 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> >> index 9436311..6f46bc6 100644
> >> --- a/drivers/platform/x86/Kconfig
> >> +++ b/drivers/platform/x86/Kconfig
> >> @@ -305,6 +305,7 @@ config EEEPC_LAPTOP
> >> __ __ __ select BACKLIGHT_CLASS_DEVICE
> >> __ __ __ select HWMON
> >> __ __ __ select RFKILL
> >> + __ __ select INPUT
> >> __ __ __ ---help---
> >> __ __ __ __ This driver supports the Fn-Fx keys on Eee PC laptops.
> >> __ __ __ __ It also adds the ability to switch camera/wlan on/off.
> >
> > I'm getting
> >
> > drivers/input/Kconfig:9:error: found recursive dependency: INPUT -> EEEPC_LAPTOP -> INPUT
> > make[1]: *** [oldconfig] Error 1
> >

(top-posting repaired.  Please don't - it makes it really hard to reply
to you)

> There was a patch collision in -mm
> It seems a patch with "depends INPUT" was already merged
> I used select because ASUS_LAPTOP and THINKPAD_ACPI are using select
> two, but for INPUT it's not realy needed.
> Maybe we should do a sed '/select INPUT/depends on INPUT/
> drivers/platform/x86/Kconfig
> 

I hate `select' and will gleefully leap on any s/select/depends/ patch,
whether it works or not :)