From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Zhang Rui <rui.zhang@intel.com>
Cc: linux-acpi <linux-acpi@vger.kernel.org>,
Len Brown <lenb@kernel.org>, Thomas Renninger <trenn@suse.de>
Subject: Re: [RFC PATCH 4/5] ACPI video: support reversed _BCL method
Date: Tue, 10 Mar 2009 17:08:01 +0000 [thread overview]
Message-ID: <20090310170801.GB2527@srcf.ucam.org> (raw)
In-Reply-To: <1236672211.2820.122.camel@rzhang-dt>
On Tue, Mar 10, 2009 at 04:03:31PM +0800, Zhang Rui wrote:
> + } else if (max_level != br->levels[count - 1]) {
> + ACPI_ERROR((AE_INFO,
> + "Brightness levels in _BCL is in a mess\n"));
> + goto out_free_levels;
Again, I don't think failing here is the best thing - I think bizarre
behaviour is preferable to entirely unworking.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2009-03-10 17:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-10 8:03 [RFC PATCH 4/5] ACPI video: support reversed _BCL method Zhang Rui
2009-03-10 17:08 ` Matthew Garrett [this message]
2009-03-10 17:11 ` Matthew Garrett
2009-03-11 1:42 ` Zhang Rui
2009-03-11 1:45 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090310170801.GB2527@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox