From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Zhang Rui <rui.zhang@intel.com>
Cc: linux-acpi <linux-acpi@vger.kernel.org>,
Len Brown <lenb@kernel.org>, Thomas Renninger <trenn@suse.de>
Subject: Re: [RFC PATCH 5/5] ACPI video: support _BQC/_BCL/_BCM methods that use index values
Date: Tue, 10 Mar 2009 17:10:00 +0000 [thread overview]
Message-ID: <20090310171000.GC2527@srcf.ucam.org> (raw)
In-Reply-To: <1236672214.2820.123.camel@rzhang-dt>
On Tue, Mar 10, 2009 at 04:03:34PM +0800, Zhang Rui wrote:
> if (level == device->brightness->levels[state]) {
> - device->backlight->props.brightness = state - 2;
> + if (device->backlight)
> + device->backlight->props.brightness = state - 2;
This hunk doesn't seem obviously related?
> + * For now, we don't support the _BCL like this:
> + * 16, 15, 0, 1, 2, 3, ..., 14, 15, 16
> + * because we may mess up the index returned by _BQC.
> + * Plus: we have not got a box like this.
Do we have any bugs that suggest there are boxes like this?
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2009-03-10 17:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-10 8:03 [RFC PATCH 5/5] ACPI video: support _BQC/_BCL/_BCM methods that use index values Zhang Rui
2009-03-10 17:10 ` Matthew Garrett [this message]
2009-03-11 1:17 ` Zhang Rui
2009-03-11 1:19 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090310171000.GC2527@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox