From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Zhang Rui <rui.zhang@intel.com>
Cc: linux-acpi <linux-acpi@vger.kernel.org>,
Len Brown <lenb@kernel.org>, Thomas Renninger <trenn@suse.de>
Subject: Re: [RFC PATCH 5/5] ACPI video: support _BQC/_BCL/_BCM methods that use index values
Date: Wed, 11 Mar 2009 01:19:36 +0000 [thread overview]
Message-ID: <20090311011936.GB13472@srcf.ucam.org> (raw)
In-Reply-To: <1236734272.2820.137.camel@rzhang-dt>
On Wed, Mar 11, 2009 at 09:17:52AM +0800, Zhang Rui wrote:
> On Wed, 2009-03-11 at 01:10 +0800, Matthew Garrett wrote:
> > This hunk doesn't seem obviously related?
> I need to set the backlight in acpi_video_init_brightness, before video
> backlight device being registered.
Ah, got you.
> > Do we have any bugs that suggest there are boxes like this?
> >
> No, we don't have one.
> So we should remove this check unless we've one _BCL like this?
I think print a warning in that case - it'd be helpful to find any that
exist, but with luck we'll never see it.
--
Matthew Garrett | mjg59@srcf.ucam.org
prev parent reply other threads:[~2009-03-11 1:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-10 8:03 [RFC PATCH 5/5] ACPI video: support _BQC/_BCL/_BCM methods that use index values Zhang Rui
2009-03-10 17:10 ` Matthew Garrett
2009-03-11 1:17 ` Zhang Rui
2009-03-11 1:19 ` Matthew Garrett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090311011936.GB13472@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox