From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Thomas Renninger <trenn@suse.de>
Cc: Zhang Rui <rui.zhang@intel.com>,
linux-acpi <linux-acpi@vger.kernel.org>,
Len Brown <lenb@kernel.org>
Subject: Re: [RFC PATCH 1/5] ACPI video: check the return value of acpi_video_device_lcd_get_level_current
Date: Wed, 11 Mar 2009 13:04:32 +0000 [thread overview]
Message-ID: <20090311130432.GA21313@srcf.ucam.org> (raw)
In-Reply-To: <200903111356.01710.trenn@suse.de>
On Wed, Mar 11, 2009 at 01:56:00PM +0100, Thomas Renninger wrote:
> (BTW, I recently saw a BIOS with _BCQ function. They said they are going to
> fix it, but it may be more widespread, e.g. this also is often the case
> (missing _BQC) on Samsung). I found it by luck disassembling and
> recompiling the DSDT, a runtime warning would be nice (if it does not
> already exist).
It's not that uncommon - there's a few machines with _BCQ. I actually
thought we handled it already, but it seems not. Just adding a cap._BCQ
and using it if there's no _BQC sounds like a safe idea.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2009-03-11 13:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-10 8:03 [RFC PATCH 1/5] ACPI video: check the return value of acpi_video_device_lcd_get_level_current Zhang Rui
2009-03-11 12:56 ` Thomas Renninger
2009-03-11 13:04 ` Matthew Garrett [this message]
2009-03-11 13:15 ` Thomas Renninger
2009-03-12 6:28 ` Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090311130432.GA21313@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox