From: Matthew Garrett <mjg59@srcf.ucam.org>
To: malattia@linux.it
Cc: linux-acpi@vger.kernel.org
Subject: [PATCH] sony-laptop: support rfkill via ACPI interfaces
Date: Thu, 19 Mar 2009 21:21:23 +0000 [thread overview]
Message-ID: <20090319212123.GA24700@srcf.ucam.org> (raw)
Enable events on all Vaio's with the new-style ACPI interface, and use
it to support rfkill where available.
Signed-off-by: Matthew Garrett <mjg@redhat.com>
---
Mattia, I didn't want to mess with the DMI stuff, but I suspect we can
probably drop the setup callbacks there and just enable them on all
hardware that supports these methods. We possibly also want to be
calling the ECON method on the SNC since some codepaths in the tables
seem to depend on them - but I'm also worried to a certain extent on how
much that might change driver interactions with some machines.
diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c
index 537959d..c57f54c 100644
--- a/drivers/platform/x86/sony-laptop.c
+++ b/drivers/platform/x86/sony-laptop.c
@@ -64,6 +64,7 @@
#include <asm/uaccess.h>
#include <linux/sonypi.h>
#include <linux/sony-laptop.h>
+#include <linux/rfkill.h>
#ifdef CONFIG_SONYPI_COMPAT
#include <linux/poll.h>
#include <linux/miscdevice.h>
@@ -143,6 +144,11 @@ struct sony_laptop_keypress {
int key;
};
+static struct rfkill *sony_wifi_rfkill;
+static struct rfkill *sony_bluetooth_rfkill;
+static struct rfkill *sony_wwan_rfkill;
+static struct rfkill *sony_wimax_rfkill;
+
/* Correspondance table between sonypi events
* and input layer indexes in the keymap
*/
@@ -981,6 +987,145 @@ static int sony_nc_resume(struct acpi_device *device)
return 0;
}
+static void sony_rfkill_cleanup(void)
+{
+ if (sony_wifi_rfkill)
+ rfkill_unregister(sony_wifi_rfkill);
+ if (sony_bluetooth_rfkill)
+ rfkill_unregister(sony_bluetooth_rfkill);
+ if (sony_wwan_rfkill)
+ rfkill_unregister(sony_wwan_rfkill);
+ if (sony_wimax_rfkill)
+ rfkill_unregister(sony_wimax_rfkill);
+}
+
+static int sony_nc_rfkill_get(void *data, enum rfkill_state *state)
+{
+ int result;
+
+ acpi_callsetfunc(sony_nc_acpi_handle, "SN07", 0x3 | ((long) data << 8),
+ &result);
+ if (result & 0xf)
+ *state = RFKILL_STATE_UNBLOCKED;
+ else
+ *state = RFKILL_STATE_SOFT_BLOCKED;
+ return 0;
+}
+
+static int sony_nc_rfkill_set(void *data, enum rfkill_state state)
+{
+ int result;
+ int call = 0x3 | (((long) data + 1) << 8);
+
+ if (state == RFKILL_STATE_UNBLOCKED)
+ call |= 0xff0000;
+
+ return acpi_callsetfunc(sony_nc_acpi_handle, "SN07", call, &result);
+}
+
+static int sony_nc_setup_wifi_rfkill(struct acpi_device *device)
+{
+ int err = 0;
+
+ sony_wifi_rfkill = rfkill_allocate(&device->dev, RFKILL_TYPE_WLAN);
+ if (!sony_wifi_rfkill)
+ return -1;
+ sony_wifi_rfkill->name = "sony-wifi";
+ sony_wifi_rfkill->toggle_radio = sony_nc_rfkill_set;
+ sony_wifi_rfkill->get_state = sony_nc_rfkill_get;
+ sony_wifi_rfkill->user_claim_unsupported = 1;
+ sony_wifi_rfkill->data = (void *)3;
+ err = rfkill_register(sony_wifi_rfkill);
+ if (err)
+ rfkill_unregister(sony_wifi_rfkill);
+ return err;
+}
+
+static int sony_nc_setup_bluetooth_rfkill(struct acpi_device *device)
+{
+ int err = 0;
+
+ sony_bluetooth_rfkill = rfkill_allocate(&device->dev,
+ RFKILL_TYPE_BLUETOOTH);
+ if (!sony_bluetooth_rfkill)
+ return -1;
+ sony_bluetooth_rfkill->name = "sony-bluetooth";
+ sony_bluetooth_rfkill->toggle_radio = sony_nc_rfkill_set;
+ sony_bluetooth_rfkill->get_state = sony_nc_rfkill_get;
+ sony_bluetooth_rfkill->user_claim_unsupported = 1;
+ sony_bluetooth_rfkill->data = (void *)5;
+ err = rfkill_register(sony_bluetooth_rfkill);
+ if (err)
+ rfkill_unregister(sony_bluetooth_rfkill);
+ return err;
+}
+
+static int sony_nc_setup_wwan_rfkill(struct acpi_device *device)
+{
+ int err = 0;
+
+ sony_wwan_rfkill = rfkill_allocate(&device->dev, RFKILL_TYPE_WWAN);
+ if (!sony_wwan_rfkill)
+ return -1;
+ sony_wwan_rfkill->name = "sony-wwan";
+ sony_wwan_rfkill->toggle_radio = sony_nc_rfkill_set;
+ sony_wwan_rfkill->get_state = sony_nc_rfkill_get;
+ sony_wwan_rfkill->user_claim_unsupported = 1;
+ sony_wwan_rfkill->data = (void *)7;
+ err = rfkill_register(sony_wwan_rfkill);
+ if (err)
+ rfkill_unregister(sony_wwan_rfkill);
+ return err;
+}
+
+static int sony_nc_setup_wimax_rfkill(struct acpi_device *device)
+{
+ int err = 0;
+
+ sony_wimax_rfkill = rfkill_allocate(&device->dev, RFKILL_TYPE_WIMAX);
+ if (!sony_wimax_rfkill)
+ return -1;
+ sony_wimax_rfkill->name = "sony-wimax";
+ sony_wimax_rfkill->toggle_radio = sony_nc_rfkill_set;
+ sony_wimax_rfkill->get_state = sony_nc_rfkill_get;
+ sony_wimax_rfkill->user_claim_unsupported = 1;
+ sony_wimax_rfkill->data = (void *)9;
+ err = rfkill_register(sony_wimax_rfkill);
+ if (err)
+ rfkill_unregister(sony_wimax_rfkill);
+ return err;
+}
+
+static int sony_nc_function_setup(struct acpi_device *device)
+{
+ int result;
+
+ /* Enable all events */
+ acpi_callsetfunc(sony_nc_acpi_handle, "SN02", 0xffff, &result);
+
+ /* Setup hotkey decoding */
+ acpi_callsetfunc(sony_nc_acpi_handle, "SN07", 0x2, &result);
+
+ /* Eaable hotkey event generation */
+ acpi_callsetfunc(sony_nc_acpi_handle, "SN07", 0, &result);
+
+ /* Set BCHA, whatever /that/ does */
+ acpi_callsetfunc(sony_nc_acpi_handle, "SN07", 0x101, &result);
+
+ acpi_callsetfunc(sony_nc_acpi_handle, "SN07", 0xb03, &result);
+
+ if (result & 0x1)
+ sony_nc_setup_wifi_rfkill(device);
+ if (result & 0x2)
+ sony_nc_setup_bluetooth_rfkill(device);
+ if (result & 0x1c)
+ sony_nc_setup_wwan_rfkill(device);
+ if (result & 0x20)
+ sony_nc_setup_wimax_rfkill(device);
+
+ return 0;
+}
+
static int sony_nc_add(struct acpi_device *device)
{
acpi_status status;
@@ -1024,6 +1169,12 @@ static int sony_nc_add(struct acpi_device *device)
dprintk("_INI Method failed\n");
}
+ if (ACPI_SUCCESS(acpi_get_handle(sony_nc_acpi_handle, "SN07",
+ &handle))) {
+ dprintk("Doing SNC setup\n");
+ sony_nc_function_setup(device);
+ }
+
/* setup input devices and helper fifo */
result = sony_laptop_setup_input(device);
if (result) {
@@ -1131,6 +1282,7 @@ static int sony_nc_add(struct acpi_device *device)
sony_laptop_remove_input();
outwalk:
+ sony_rfkill_cleanup();
return result;
}
@@ -1156,6 +1308,7 @@ static int sony_nc_remove(struct acpi_device *device, int type)
sony_pf_remove();
sony_laptop_remove_input();
+ sony_rfkill_cleanup();
dprintk(SONY_NC_DRIVER_NAME " removed.\n");
return 0;
--
Matthew Garrett | mjg59@srcf.ucam.org
next reply other threads:[~2009-03-19 21:21 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-19 21:21 Matthew Garrett [this message]
2009-03-19 21:28 ` [PATCH] sony-laptop: support rfkill via ACPI interfaces Matthew Garrett
2009-03-19 21:34 ` Norbert Preining
2009-03-19 21:44 ` Matthew Garrett
2009-03-19 21:49 ` Norbert Preining
2009-03-19 21:56 ` Matthew Garrett
2009-03-19 22:15 ` Norbert Preining
2009-03-20 0:28 ` Norbert Preining
2009-03-20 0:38 ` Matthew Garrett
2009-03-20 0:40 ` Norbert Preining
2009-03-20 1:18 ` Norbert Preining
2009-03-20 7:33 ` Matthias Welwarsky
2009-03-21 11:22 ` Matthias Welwarsky
2009-03-21 13:53 ` Matthias Welwarsky
2009-03-21 14:45 ` Mattia Dongili
2009-03-21 16:51 ` Norbert Preining
2009-03-22 17:56 ` Matthew Garrett
2009-03-22 18:03 ` Matthew Garrett
2009-03-22 20:36 ` Norbert Preining
2009-03-22 20:37 ` Matthew Garrett
2009-03-22 22:06 ` Norbert Preining
2009-03-22 22:46 ` Matthew Garrett
2009-03-22 23:10 ` Mattia Dongili
2009-03-22 23:14 ` Matthew Garrett
2009-03-23 0:08 ` Mattia Dongili
2009-03-23 0:10 ` Matthew Garrett
2009-03-23 12:30 ` Norbert Preining
2009-03-23 13:04 ` Mattia Dongili
2009-03-23 15:32 ` Norbert Preining
2009-03-23 15:43 ` Matthew Garrett
2009-03-23 16:00 ` Norbert Preining
2009-03-23 16:09 ` Matthew Garrett
2009-03-23 16:27 ` Norbert Preining
2009-03-23 16:30 ` Matthew Garrett
2009-03-23 16:37 ` Norbert Preining
2009-03-23 16:40 ` Matthew Garrett
2009-03-23 16:41 ` Norbert Preining
2009-03-23 16:51 ` Matthew Garrett
2009-03-23 17:48 ` Norbert Preining
2009-03-23 19:51 ` Matthew Garrett
2009-03-24 0:01 ` Norbert Preining
2009-03-24 0:08 ` Mattia Dongili
2009-03-23 21:48 ` Matthew Garrett
2009-03-24 0:02 ` Norbert Preining
2009-03-24 0:04 ` Matthew Garrett
2009-03-23 12:29 ` Norbert Preining
2009-03-23 14:58 ` Matthew Garrett
2009-03-21 16:18 ` Norbert Preining
2009-03-20 8:52 ` Mattia Dongili
2009-03-20 14:00 ` Matthew Garrett
2009-03-21 4:00 ` Mattia Dongili
2009-03-21 4:35 ` Matthew Garrett
2009-03-21 6:32 ` Mattia Dongili
2009-03-21 14:06 ` Matthew Garrett
2009-03-21 14:37 ` Mattia Dongili
2009-03-21 14:55 ` Matthew Garrett
2009-03-21 15:10 ` Matthew Garrett
2009-03-21 19:15 ` Matthias Welwarsky
2009-03-22 13:33 ` Matthew Garrett
2009-03-22 2:38 ` Mattia Dongili
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090319212123.GA24700@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=linux-acpi@vger.kernel.org \
--cc=malattia@linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox