Re: [PATCH] sony-laptop: support rfkill via ACPI interfaces

Matthew Garrett
2009-03-21T14:06:59Z

On Sat, Mar 21, 2009 at 03:32:30PM +0900, Mattia Dongili wrote:

> sure, that DMI whitelist is already annoying in its current shape.
> Getting the ACPI tables to tell us what SNC version we are looking at
> would be so much better.
> I just grepped the DSDTs I have here and this is what I got:
> DSDT.c1s.dsl: Name (SNI4, 0x344A0001)
> DSDT.c71bw.dsl: Name (SNI4, 0x344A0001)

(snip)

The second byte seems to be the most consistent here - 0x4a for the
models currently handled by the nc code, 0x4d for the tt and z, 0x55 for
the p. I've no idea whether this is a monotonically increasing version
string or a bitmask of supported functionality, but it ought to be
enough to key off to begin with.

> want to try to push your patch to mainline or would you prefer to wait?
> IMO pushing it and eventually fixing support for 0x344a000[10] models is
> fine. After all your snc_setup code could be easily plugged into the DMI
> list for the time being and Z and TT users would be happy.

Might as well push it and see what happens?

--
Matthew Garrett | mjg59@srcf.ucam.org