Re: [PATCH] sony-laptop: support rfkill via ACPI interfaces

Matthias Welwarsky
2009-03-20T07:58:28Z

On Friday 20 March 2009 02:18:37 Norbert Preining wrote:
> Hi all,
>
> On Fr, 20 Mär 2009, Norbert Preining wrote:
> > > As far as we can tell, the handling of the handover is consistent
> > > across all dual-GPU nvidia laptops[1]. The right place for support to
> > > end up is in the kernel component of the nouveau drivers.
> >
> > Whatever the nouveau drivers are? You mean those based on the kernel
> > mode swching? Unfortunately that is far from prime time, and we need
> > power saving now.
> >
> > I will take a look over the weekend maybe I can add a patch ontop of
> > yours that only does that, taken from the code in the special vaio-Z
> > sony-laptop module.
> >
> > Now it would be nice to merge over *only* the stuff concerning
> > speed/stamina into the in-kernel driver added with the patch for rfkill
> > support.
>
> Ok, here is the code.
>
> For those interested I Cc the sony-vaio-z-series@lists.launchpad.net
> group where I first found that modules.
>
> You need:
> kernel 2.6.29-rc8 (maybe it works with all from .28 on)
> the patch Matthew sent
> the attached patch
>
> Together you get full rfkill support for bluetooth/wwan/wifi, plus afais
> stamina-speed mode setting.
>
> Maybe Matthias the creator of the sony-laptop for vaio-zseries modules
> can take a look at the patch and see if I missed something.

Too much of honour ;) I only took the in-kernel module as a base for my
experiments. But I'll have a look this weekend.

> Matthias: sony_led_off and sony_dgpu_sta is never used, is that
> intentional? And also the #define SONY_WMMX_GUID I couldn't find being
> used anywhere.

sony_led_off is an experiment vehicle only, and sony_dgpu_sta can be used to
query the power state of the nvidia adapter. It's in there for demonstration
purposes.

> Maybe Matthew can take a look and fix the compile warnings in function
> ‘sony_ovga_dsm’ (there are some!).

I'm aware of that. Most are in debug code, though, which can be removed safely
without changing the functionality.

> My intention is that we do not digress too far from the kernel code of
> sony-laptop making eventual merging possible.
>
> Best wishes
>
> Norbert
>
> ---------------------------------------------------------------------------
>---- Dr. Norbert Preining <preining@logic.at> Vienna University of
> Technology Debian Developer <preining@debian.org>
> Debian TeX Group gpg DSA: 0x09C5B094 fp: 14DF 2E6C 0307 BE6D AD76
> A9C0 D2BF 4AA3 09C5 B094
> ---------------------------------------------------------------------------
>---- OSBASTON (n.)
> A point made for the seventh time to somebody who insists that they
> know exactly what you mean but clearly hasn't got the faintest idea.
> --- Douglas Adams, The Meaning of Liff

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html