Re: [PATCH 57/98] sony-laptop: Add support for extra keyboard events

Matthew Garrett
2009-03-29T16:02:17Z

On Sun, Mar 29, 2009 at 05:51:45PM +0200, Matthias Welwarsky wrote:
> before the call to acpi_bus_generate_proc_event(). It was called
> unconditionally, with whatever value ev happened to have at that time, i.e.
> also unprocessed events < 0x90 or events where the translation failed. Moving
> the call makes sure that only properly processed events are reported. Without,
> I was seeing a lot of bogus events reported, e.g. volume-down when the stamina
> switch was flipped, or when the rf kill switch was operated.

Oh, I see. No, you can't just remove it from there - that'll break
older-style events. I'd add it there without removing the original, but
then make the rest of the block conditional on the original event not
being >= 0x90.

--
Matthew Garrett | mjg59@srcf.ucam.org