Re: [PATCH 57/98] sony-laptop: Add support for extra keyboard events

Matthew Garrett
2009-03-29T15:03:48Z

On Sun, Mar 29, 2009 at 12:53:04PM +0200, Matthias Welwarsky wrote:
> { 0x90, SONYPI_EVENT_PKEY_P1 },
> { 0x10, SONYPI_EVENT_ANYBUTTON_RELEASED },
> - { 0x91, SONYPI_EVENT_PKEY_P1 },
> + { 0x91, SONYPI_EVENT_PKEY_P2 },
> { 0x11, SONYPI_EVENT_ANYBUTTON_RELEASED },
> { 0x81, SONYPI_EVENT_FNKEY_F1 },
> { 0x01, SONYPI_EVENT_FNKEY_RELEASED },

Oops, yes...

> @@ -929,7 +929,7 @@
> if (sony_find_snc_handle(0x127) == ev)
> key_handle = 0x127;
>
> - if (handle) {
> + if (key_handle) {

Indeed.

> - }
> + } else
> + sony_laptop_report_input_event(ev);

That doesn't look right, though - sony_laptop_report_input_event expects
a value that matches the input_index array, and an unprocessed event
>0x90 isn't going to satisfy that.

--
Matthew Garrett | mjg59@srcf.ucam.org