Re: [PATCH 21/98] ACPICA: Check for non-zero address before being converted to GAS

Thomas Renninger
2009-04-02T11:59:04Z

On Saturday 28 March 2009 05:30:56 Len Brown wrote:
> From: Lin Ming <ming.m.lin@intel.com>
>
> Reported-by: FreeBSD community
> Signed-off-by: Lin Ming <ming.m.lin@intel.com>
> Signed-off-by: Len Brown <len.brown@intel.com>
Does this fix something for real?
If yes, please add:
CC: stable@kernel.org
not sure if not.
> ---
> drivers/acpi/acpica/tbfadt.c | 16 +++++++++-------
> 1 files changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/acpi/acpica/tbfadt.c
b/drivers/acpi/acpica/tbfadt.c
> index a8191ef..43fe886 100644
> --- a/drivers/acpi/acpica/tbfadt.c
> +++ b/drivers/acpi/acpica/tbfadt.c
> @@ -618,12 +618,14 @@ static void acpi_tb_setup_fadt_registers(void)
> ACPI_ADD_PTR(struct acpi_generic_address, &acpi_gbl_FADT,
> fadt_pm_info_table[i].source);
>
> - acpi_tb_init_generic_address(fadt_pm_info_table[i].target,
> - source64->space_id,
> - pm1_register_byte_width,
> - source64->address +
> - (fadt_pm_info_table[i].
> - register_num *
> - pm1_register_byte_width));
> + if (source64->address) {
> + acpi_tb_init_generic_address(fadt_pm_info_table[i].
> + target, source64->space_id,
> + pm1_register_byte_width,
> + source64->address +
> + (fadt_pm_info_table[i].
> + register_num *
> + pm1_register_byte_width));
> + }
> }
> }
> --