Re: [PATCH 41/98] ACPICA: FADT: Fix extraneous length mismatch warning

Thomas Renninger
2009-04-02T11:53:16Z

On Saturday 28 March 2009 05:31:16 Len Brown wrote:
> From: Bob Moore <robert.moore@intel.com>
>
> Incorrect register length mismatch between the 32 and 64 bit
> registers in some cases. Code was was checking the wrong pointer
> for non-zero, should be looking at the address within the GAS
> structure.
>
> Signed-off-by: Bob Moore <robert.moore@intel.com>
> Signed-off-by: Lin Ming <ming.m.lin@intel.com>
> Signed-off-by: Len Brown <len.brown@intel.com>
> ---
> drivers/acpi/acpica/tbfadt.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/acpi/acpica/tbfadt.c
b/drivers/acpi/acpica/tbfadt.c
> index af8fbe1..ff89cfe 100644
> --- a/drivers/acpi/acpica/tbfadt.c
> +++ b/drivers/acpi/acpica/tbfadt.c
> @@ -491,7 +491,8 @@ static void acpi_tb_validate_fadt(void)
> * For each extended field, check for length mismatch between the
> * legacy length field and the corresponding 64-bit X length
field.
> */
> - if (address64 && (address64->bit_width != ACPI_MUL_8(length))) {
> + if (address64->address &&
> + (address64->bit_width != ACPI_MUL_8(length))) {
> ACPI_WARNING((AE_INFO,
> "32/64X length mismatch in %s: %d/%d",
> name, ACPI_MUL_8(length),
This is a firmware bug for sure and should be marked as such.
ACPI_WARNING((AE_INFO, FW_BUG "32/64X
Can acpica take over and implement these from include/kernel.h if
compiled standalone:
#define FW_BUG "[Firmware Bug]: "
#define FW_WARN "[Firmware Warn]: "
#define FW_INFO "[Firmware Info]: "

Thomas