linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthew Garrett <mjg59@srcf.ucam.org>
To: linux-acpi@vger.kernel.org
Cc: dsilvers@simtec.co.uk, toshiba_acpi@memebeam.org,
	linux-kernel@vger.kernel.org, lenb@intel.com
Subject: [PATCH 2/2] toshiba-acpi: Support TOS1900-type devices
Date: Tue, 31 Mar 2009 22:47:49 +0100	[thread overview]
Message-ID: <20090331214749.GD29489@srcf.ucam.org> (raw)
In-Reply-To: <20090331214501.GC29489@srcf.ucam.org>

Despite toshiba_acpi exporting TOS1900 as a modalias, it doesn't appear to
support these machines. They have their HCI method implemented in a
different but compatible manner and so need a different method address.

Signed-off-by: Matthew Garrett <mjg@redhat.com>
---
 drivers/platform/x86/toshiba_acpi.c |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c
index fb87b57..9fb4873 100644
--- a/drivers/platform/x86/toshiba_acpi.c
+++ b/drivers/platform/x86/toshiba_acpi.c
@@ -67,6 +67,7 @@ MODULE_LICENSE("GPL");
 #define TOSH_INTERFACE_2	"\\_SB_.VALZ"
 #define METHOD_VIDEO_OUT	"\\_SB_.VALX.DSSX"
 #define GHCI_METHOD		".GHCI"
+#define SPFC_METHOD		".SPFC"
 
 /* Toshiba HCI interface definitions
  *
@@ -935,6 +936,10 @@ static int __init toshiba_acpi_init(void)
 		method_hci = TOSH_INTERFACE_2 GHCI_METHOD;
 		if (toshiba_acpi_setup_keyboard(TOSH_INTERFACE_2))
 			printk(MY_INFO "Unable to activate hotkeys\n");
+	} else if (is_valid_acpi_path(TOSH_INTERFACE_2 SPFC_METHOD)) {
+		method_hci = TOSH_INTERFACE_2 SPFC_METHOD;
+		if (toshiba_acpi_setup_keyboard(TOSH_INTERFACE_2))
+			printk(MY_INFO "Unable to activate hotkeys\n");
 	} else
 		return -ENODEV;
 
-- 
Matthew Garrett | mjg59@srcf.ucam.org

  reply	other threads:[~2009-03-31 21:47 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-31 21:45 [PATCH 1/2] toshiba-acpi: Add support for hotkey notifications Matthew Garrett
2009-03-31 21:47 ` Matthew Garrett [this message]
2009-03-31 22:06   ` [PATCH 2/2] toshiba-acpi: Support TOS1900-type devices Azael Avalos
2009-03-31 22:11     ` Matthew Garrett
2009-03-31 22:19       ` Azael Avalos
2009-03-31 23:02         ` Matthew Garrett
2009-04-01 16:50           ` Azael Avalos
2009-04-01 16:53             ` Matthew Garrett
2009-04-01 17:03               ` Azael Avalos
2009-04-01 17:07                 ` Matthew Garrett
2009-04-01 17:13                   ` Azael Avalos
2009-06-02 14:03                     ` Matthew Garrett
2009-06-09 16:42                       ` Azael Avalos
2009-06-09 16:45                         ` Matthew Garrett
2009-06-10  0:18                           ` Azael Avalos
2009-06-10  0:22                             ` Matthew Garrett
2009-06-10  0:29                               ` Azael Avalos
2009-06-18  0:35                                 ` Azael Avalos
2009-04-08  5:44 ` [PATCH 1/2] toshiba-acpi: Add support for hotkey notifications Len Brown
2009-04-11 19:50 ` Frans Pop
2009-04-13 14:50   ` Matthew Garrett
2009-04-13 19:28     ` Frans Pop
2009-04-13 19:43       ` Matthew Garrett
2009-04-13 20:38         ` Frans Pop
2009-04-13 21:18           ` Matthew Garrett
2009-04-13 21:26             ` Frans Pop
2009-04-13 21:31               ` Matthew Garrett
2009-04-11 23:06 ` Benoit Izac
2009-04-18  4:01 ` Len Brown
2009-04-18  5:47   ` Andrey Borzenkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090331214749.GD29489@srcf.ucam.org \
    --to=mjg59@srcf.ucam.org \
    --cc=dsilvers@simtec.co.uk \
    --cc=lenb@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=toshiba_acpi@memebeam.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).