From: Thomas Renninger <trenn@suse.de>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>, Alexander Graf <agraf@suse.de>
Cc: kamezawa.hiroyu@jp.fujitsu.com, y-goto@jp.fujitsu.com,
Len Brown <lenb@kernel.org>, Tony Vroon <tony@linx.net>,
Alex Chiang <achiang@hp.com>,
linux-acpi@vger.kernel.org,
Carlos Corbacho <carlos@strangeworlds.co.uk>,
Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
Jonathan Woithe <jwoithe@physics.adelaide.edu.au>,
Zhao Yakui <yakui.zhao@intel.com>,
Mattia Dongili <malattia@linux.it>,
Harald Welte <laforge@gnumonks.org>,
Venki Pallipadi <venkatesh.pallipadi@intel.com>,
Alexey Starikovskiy <alexey.y.starikovskiy@linux.intel.com>,
Zhang Rui <rui.zhang@intel.com>, Matthew Garrett <mjg@redhat.com>
Subject: Re: [PATCH 01/10] ACPI: support acpi_device_ops .notify methods
Date: Fri, 3 Apr 2009 15:14:47 +0200 [thread overview]
Message-ID: <200904031514.50482.trenn@suse.de> (raw)
In-Reply-To: <200904020903.21140.bjorn.helgaas@hp.com>
On Thursday 02 April 2009 17:03:19 Bjorn Helgaas wrote:
> On Thursday 02 April 2009 07:56:28 am Thomas Renninger wrote:
> > On Monday 30 March 2009 19:48:13 Bjorn Helgaas wrote:
> > > This patch adds support for ACPI device driver .notify() methods. If
> > > such a method is present, Linux/ACPI installs a handler for device
> > > notifications (but not for system notifications such as Bus Check,
> > > Device Check, etc). When a device notification occurs, Linux/ACPI
> > > passes it on to the driver's .notify() method.
> > I sent more or less the same some years ago.
> > Thanks a lot for finally cleaning this up!
>
> Hi Thomas,
>
> Oh, sorry, I didn't know that, or I would have given you some credit :-)
> In fact, if you have a URL, I'll add a pointer to the changelog. I
> always like to leave breadcrumbs to help future research.
I only find the acpi_memhotplug things, but I remember I suggested
(maybe privately?) to introduce a .notify callback.
Hmm, I even had some code, but got cold feet when I realized that not
present devices have to call .add or .start functions...
While this is not much worth crediting :), I just want to give you the
feedback I missed, IMO you are going the right way.
Thomas
next prev parent reply other threads:[~2009-04-03 13:15 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-30 17:48 [PATCH 00/10] ACPI: add device .notify methods Bjorn Helgaas
2009-03-30 17:48 ` [PATCH 01/10] ACPI: support acpi_device_ops " Bjorn Helgaas
2009-04-02 13:56 ` Thomas Renninger
2009-04-02 15:03 ` Bjorn Helgaas
2009-04-03 0:23 ` Yasunori Goto
2009-04-03 9:08 ` Thomas Renninger
2009-04-03 15:09 ` Bjorn Helgaas
2009-04-03 22:43 ` Yasunori Goto
2009-04-03 13:14 ` Thomas Renninger [this message]
2009-03-30 17:48 ` [PATCH 02/10] ACPI: button: use .notify method instead of installing handler directly Bjorn Helgaas
2009-03-30 17:48 ` [PATCH 03/10] ACPI: processor: " Bjorn Helgaas
2009-03-30 17:48 ` [PATCH 04/10] ACPI: thermal: " Bjorn Helgaas
2009-03-30 17:48 ` [PATCH 05/10] ACPI: video: " Bjorn Helgaas
2009-03-30 17:48 ` [PATCH 06/10] fujitsu-laptop: " Bjorn Helgaas
2009-03-31 6:45 ` [PATCH 06/10] fujitsu-laptop: use .notify method instead of Jonathan Woithe
2009-03-31 21:38 ` [PATCH 06/10] fujitsu-laptop: use .notify method instead of installing handler directly Tony Vroon
2009-03-31 22:09 ` Bjorn Helgaas
2009-03-31 22:09 ` Tony Vroon
2009-03-31 22:29 ` Jonathan Woithe
2009-03-30 17:48 ` [PATCH 07/10] fujitsu-laptop: use .notify method instead of installing hotkey " Bjorn Helgaas
2009-03-31 21:39 ` Tony Vroon
2009-03-31 22:30 ` [PATCH 07/10] fujitsu-laptop: use .notify method instead of installing " Jonathan Woithe
2009-03-30 17:48 ` [PATCH 08/10] panasonic-laptop: " Bjorn Helgaas
2009-03-30 17:48 ` [PATCH 09/10] sony-laptop: " Bjorn Helgaas
2009-03-31 13:46 ` Mattia Dongili
2009-03-31 22:58 ` Mattia Dongili
2009-03-30 17:48 ` [PATCH 10/10] ACPI: WMI: " Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904031514.50482.trenn@suse.de \
--to=trenn@suse.de \
--cc=achiang@hp.com \
--cc=agraf@suse.de \
--cc=alexey.y.starikovskiy@linux.intel.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=bjorn.helgaas@hp.com \
--cc=carlos@strangeworlds.co.uk \
--cc=jwoithe@physics.adelaide.edu.au \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=laforge@gnumonks.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=malattia@linux.it \
--cc=mjg@redhat.com \
--cc=rui.zhang@intel.com \
--cc=tony@linx.net \
--cc=venkatesh.pallipadi@intel.com \
--cc=y-goto@jp.fujitsu.com \
--cc=yakui.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox