From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Garrett Subject: Re: [patch 4/4] dell-wmi: support additional keys Date: Mon, 13 Apr 2009 15:55:23 +0100 Message-ID: <20090413145522.GC10976@srcf.ucam.org> References: <200904110616.n3B6GXsp026164@imap1.linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from cavan.codon.org.uk ([93.93.128.6]:55433 "EHLO vavatch.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751944AbZDMO4K (ORCPT ); Mon, 13 Apr 2009 10:56:10 -0400 Content-Disposition: inline In-Reply-To: <200904110616.n3B6GXsp026164@imap1.linux-foundation.org> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: akpm@linux-foundation.org Cc: lenb@kernel.org, linux-acpi@vger.kernel.org, rafi@seas.upenn.edu, E.A.B.Piel@tudelft.nl, len.brown@intel.com On Fri, Apr 10, 2009 at 11:16:32PM -0700, akpm@linux-foundation.org wrote: > From: Rafi Rubin > > Added key codes generated by screen rotation on the Latitude XT. 0xe046 > is sent when changing to tablet mode, and 0xe047 when it returns to > desktop mode. > > Signed-off-by: Rafi Rubin > Cc: Matthew Garrett > Cc: Len Brown > Cc: Eric Piel > Signed-off-by: Andrew Morton I don't like this - it should really be using the switch event, not sending random programmable buttons. -- Matthew Garrett | mjg59@srcf.ucam.org