From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: akpm@linux-foundation.org
Cc: lenb@kernel.org, linux-acpi@vger.kernel.org,
randy.dunlap@oracle.com, hpa@zytor.com, mingo@elte.hu,
mjg59@srcf.ucam.org, tglx@linutronix.de
Subject: Re: [patch 1/8] x86: oqo: depends on INPUT_POLLDEV
Date: Mon, 13 Apr 2009 19:16:40 -0700 [thread overview]
Message-ID: <200904131916.40428.dmitry.torokhov@gmail.com> (raw)
In-Reply-To: <200903041955.n24JtOKb027987@imap1.linux-foundation.org>
On Wednesday 04 March 2009 11:55:24 akpm@linux-foundation.org wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> oqo driver uses polled input functions, so make it depend
> on INPUT_POLLDEV.
>
> ERROR: "input_register_polled_device" [drivers/platform/x86/oqo-wmi.ko]
> undefined! ERROR: "input_allocate_polled_device"
> [drivers/platform/x86/oqo-wmi.ko] undefined! ERROR:
> "input_free_polled_device" [drivers/platform/x86/oqo-wmi.ko] undefined!
> ERROR: "input_unregister_polled_device" [drivers/platform/x86/oqo-wmi.ko]
> undefined!
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: Matthew Garrett <mjg59@srcf.ucam.org>
> Cc: Ingo Molnar <mingo@elte.hu>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: Len Brown <lenb@kernel.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> drivers/platform/x86/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -puN drivers/platform/x86/Kconfig~x86-oqo-depends-on-input_polldev
> drivers/platform/x86/Kconfig ---
> a/drivers/platform/x86/Kconfig~x86-oqo-depends-on-input_polldev +++
> a/drivers/platform/x86/Kconfig
> @@ -137,7 +137,7 @@ config MSI_LAPTOP
> config OQO_WMI
> tristate "OQO WMI extras"
> depends on ACPI_WMI
> - depends on INPUT
> + depends on INPUT && INPUT_POLLDEV
Make it "select INPUT_POLLDEV". Input-polldev is just a library code, users
should not have to select it for some drivers to become available.
--
Dmitry
next prev parent reply other threads:[~2009-04-14 2:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-04 19:55 [patch 1/8] x86: oqo: depends on INPUT_POLLDEV akpm
2009-03-16 3:05 ` Len Brown
2009-04-14 2:16 ` Dmitry Torokhov [this message]
2009-04-14 17:25 ` Randy Dunlap
2009-04-20 4:27 ` Len Brown
2009-05-20 1:22 ` x86 platform: oqo: select INPUT_POLLDEV Randy Dunlap
2009-05-20 2:28 ` Dmitry Torokhov
2009-05-27 20:34 ` Len Brown
2009-05-27 23:03 ` Matthew Garrett
2009-05-30 0:52 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904131916.40428.dmitry.torokhov@gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mjg59@srcf.ucam.org \
--cc=randy.dunlap@oracle.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).