From: Thomas Renninger <trenn@suse.de>
To: "Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>
Cc: "lenb@kernel.org" <lenb@kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"cpufreq@vger.kernel.org" <cpufreq@vger.kernel.org>
Subject: Re: [PATCH 4/8] acpi-cpufreq: Do not let get_measured perf depend on internal variable
Date: Sat, 18 Apr 2009 11:49:36 +0200 [thread overview]
Message-ID: <200904181149.37228.trenn@suse.de> (raw)
In-Reply-To: <1239989077.4529.8644.camel@localhost.localdomain>
On Friday 17 April 2009 07:24:37 pm Pallipadi, Venkatesh wrote:
> Ack.
>
> I am not sure below printk is adding much value though, considering
> cpufreq_frequency_table_cpuinfo() that is initializing cpuinfo.max_freq
> is getting called just one line before this code.
It handles the BIOS bug case that P0 is not max_freq.
It should never happen...
Better would be to check at _PSS call time that all frequencies
are in the right order and throw a FW_BUG then (if that is not done already).
Len can you apply this with the last hunk thrown out then, please.
Thanks,
Thomas
next prev parent reply other threads:[~2009-04-18 9:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-17 14:22 acpi-cpufreq: Move average performance code and make it available to userspace and several cleanups in this area Thomas Renninger
2009-04-17 14:22 ` [PATCH 1/8] Fix for a regression that was introduced by earlier commit Thomas Renninger
2009-04-18 5:30 ` Len Brown
2009-04-17 14:22 ` [PATCH 2/8] acpi-cpufreq: Cleanup: Use printk_once Thomas Renninger
2009-04-18 5:31 ` Len Brown
2009-04-17 14:22 ` [PATCH 3/8] acpi-cpufreq: First multiply then divide to avoid zero results Thomas Renninger
2009-04-17 17:10 ` Pallipadi, Venkatesh
2009-04-18 5:37 ` Len Brown
2009-04-17 14:22 ` [PATCH 4/8] acpi-cpufreq: Do not let get_measured perf depend on internal variable Thomas Renninger
2009-04-17 17:24 ` Pallipadi, Venkatesh
2009-04-18 9:49 ` Thomas Renninger [this message]
2009-04-17 14:22 ` [PATCH 5/8] acpi-cpufreq: Move average performance funtions into separate file and KConfig Thomas Renninger
2009-04-17 17:32 ` Pallipadi, Venkatesh
2009-04-20 11:41 ` Thomas Renninger
2009-04-20 17:04 ` Pallipadi, Venkatesh
2009-04-17 14:22 ` [PATCH 6/8] CPUFREQ: Add average frequency to sysfs exported files of cpufreq_stats Thomas Renninger
2009-04-17 14:22 ` [PATCH 7/8] acpi-cpufreq: Use already defined IDA feature flag instead of checking cpuid Thomas Renninger
2009-04-17 17:35 ` Pallipadi, Venkatesh
2009-04-17 14:22 ` [PATCH 8/8] CPUFREQ: Add documentation for new average_freq cpufreq_stats sysfs file Thomas Renninger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904181149.37228.trenn@suse.de \
--to=trenn@suse.de \
--cc=cpufreq@vger.kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox