Re: [PATCH] PM/Suspend: Introduce two new platform callbacks to avoid breakage (Re: 900af0d breaks some embedded suspend/resume)

Russell King
2009-04-20T08:35:23Z

On Mon, Apr 20, 2009 at 09:31:47AM +1000, Nigel Cunningham wrote:
> > }
> >
> > - if (suspend_ops->prepare) {
> > - error = suspend_ops->prepare();
> > + if (suspend_ops->prepare_late) {
> > + error = suspend_ops->prepare_late();
> > if (error)
> > goto Power_up_devices;
> > }
>
> Doesn't this invalidate testing that's already been done? Drivers
> implementing prepare() (arm omap1, pxa, omap2, s3c and powerpc mpc52xx
> and lite5200) are now going to have it called pre device_power_down.

... which is the way it has always been done prior to the change which
broke stuff. So this patch is putting the ordering back the way it was
which has been well proven to work on these platforms.

So we're not invalidating any testing.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/