Re: 2.6.30-rc3 video/i915 build error

yakui_zhao
2009-04-24T03:45:45Z

On Fri, 2009-04-24 at 09:57 +0800, Len Brown wrote:

Hi, Len
In my test if VIDEO_OUTPUT_CONTROL is not selected, there exists the
following failure:
>drivers/built-in.o: In function `acpi_video_bus_put_devices':
>video.c:(.text+0x41307): undefined reference to
`video_output_unregister'
>drivers/built-in.o: In function `acpi_video_bus_add':
video.c:(.text+0x43024): undefined reference to `video_output_register'
>make: *** [.tmp_vmlinux1] Error 1

In order to fix this issue we must select the VIDEO_OUTPUT_CONTROL
when ACPI_VIDEO is selected.
I add the following content in drivers/gpu/drm/Kconfig
>select ACPI_VIDEO if ACPI
>select VIDEO_OUTPUT_CONTROL if ACPI_VIDEO

And then it will report that there exits recursive dependency:
ACPI_VIDEO -> VIDEO_OUTPUT_CONTROL -> ACPI_VIDEO

In fact in current kernel there exists the following dependency:
ACPI_VIDEO depends on VIDEO_OUTPUT_CONTROL.

If we delete the ACPI_VIDEO configuration in drivers/acpi/Kconfig,
we can't select the acpi_video configuration when i915 is not used.

So IMO it is not very good to change the dependency. After changing
the dependency between ACPI_VIDEO and I915, the new issue about
dependency is triggered.

Thanks.
>
> thanks,
> Len Brown, Intel Open Source Technology Center
>
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html