Re: 2.6.30-rc3 video/i915 build error

yakui_zhao
2009-04-28T06:01:51Z

On Fri, 2009-04-24 at 23:49 +0800, Len Brown wrote:
> From: Len Brown <len.brown@intel.com>
> Subject: [PATCH] ACPI, i915: build fix
Hi, Len
It seems that the issue still exists if KMS is not set in kernel
configuration.

Maybe this should depend on whether the I915 is selected.

thanks.

>
> drivers/built-in.o: In function `intel_opregion_init':
> (.text+0x9d540): undefined reference to `acpi_video_register'
>
> Signed-off-by: Len Brown <len.brown@intel.com>
> ---
> drivers/gpu/drm/Kconfig | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
> index 3a22eb9..f33d252 100644
> --- a/drivers/gpu/drm/Kconfig
> +++ b/drivers/gpu/drm/Kconfig
> @@ -83,6 +83,12 @@ config DRM_I915
> config DRM_I915_KMS
> bool "Enable modesetting on intel by default"
> depends on DRM_I915
> + # i915 KMS depends on ACPI_VIDEO when ACPI is enabled
> + # but for select to work, need to select ACPI_VIDEO's dependencies, ick
> + select VIDEO_OUTPUT_CONTROL if ACPI
> + select BACKLIGHT_CLASS_DEVICE if ACPI
> + select INPUT if ACPI
> + select ACPI_VIDEO if ACPI
> help
> Choose this option if you want kernel modesetting enabled by default,
> and you have a new enough userspace to support this. Running old