public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Thomas Renninger <trenn@suse.de>
To: Olivier Berger <oberger@ouvaton.org>
Cc: linux-acpi@vger.kernel.org
Subject: Re: Incorrect ACPI blacklisting of ASUS P4B266 ?
Date: Mon, 27 Apr 2009 12:18:02 +0200	[thread overview]
Message-ID: <200904271218.02906.trenn@suse.de> (raw)
In-Reply-To: <87ws98r0fl.fsf@olivierberger.com>

On Saturday 25 April 2009 21:35:42 Olivier Berger wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Hi.
> 
> Following advice from Thomas Renninger, I hereby propose a patch for the
> ACPI blacklisting kernel code, that I've successfully applied to kernel
> 2.6.26-15, that allows ACPI detection on Asus P4B266 mainboards.
Hmm, there seem to be different models of this motherboard series:
P4B266
P4B266-C
P4B266-E
P4B266-M
P4B266-SE

P4B266 and P4B266-SE seem to have a similar BIOS history and the latest
for both is: Beta Version 1011.003 

The rest has a similar version string, but different latest BIOS versions
(e.g. 1007)

The dmi blacklisting currently done in the kernel is probably matching
all of above and is rather unfortunate.
We could have:
  - A BIOS update which makes all of above models work with acpi(=force)
    well. Then your patch is perfect.

  - One or more of above (latest) BIOSes does not work well with acpi=force
    still.
    Then we'd get regressions and some people will moan about that and
    the patch will get reverted. In this case we should find out which
    kind of BIOS/mainboard it is and enhance the blacklisting to only
    match this(these) -> dmidecode is needed to be able to blacklist more
    fine grained.

> Maybe there could be a smarter version that would allow blacklisting for
> same mainboards with older BIOS versions than the one I'm using, but I
> don't know if/how that'd be possible. So the patch I propose is pretty
> obvious.
> 
> FYI, here are some reports that mention acpi=force working succesfully
> for P4B266 mainboards (in english and german) :
> 
> http://forums.fedoraforum.org/showpost.php?p=669615&postcount=5 / http://fedoraforum.org/forum/showpost.php?p=669615&postcount=5
> https://lists.ubuntu.com/archives/kernel-bugs/2006-November/023486.html / https://bugs.launchpad.net/linux/+bug/43961/comments/145
> http://forum.ubuntuusers.de/topic/automatische-abschaltung/#post-249151
> http://www.pc-forum24.de/suse-system-installieren/3031-suse-10-2-laesst-sich-nicht-ausschalten.html#post13729
> 
> I hope this won't break things for different BIOS versions than mine,
That's the risk and we should try to find out more first.

I wonder whether it's worth that at all, one of the latest BIOSes is from:
2003/06/10

> and that this will on the other hand allow lots of users to benefit from
> working ACPI.
It should be best if you state in above references that these guys
must use acpi=force.
Others should find it then via google.
That's the easiest and safest way.
I tried to find out who and why this got added, but this exists even before
git history...


     Thomas

  reply	other threads:[~2009-04-27 10:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-28 15:32 Incorrect ACPI blacklisting of ASUS P4B266 ? Olivier Berger
     [not found] ` <200904021502.31021.trenn@suse.de>
2009-04-25 19:35   ` Olivier Berger
2009-04-27 10:18     ` Thomas Renninger [this message]
2009-04-28  6:09       ` Olivier Berger
2009-04-28 11:39         ` Thomas Renninger
2009-04-28 17:15           ` Olivier Berger
2009-04-28 17:56             ` Thomas Renninger
2009-04-30  4:22               ` Olivier Berger
2009-05-06  6:11                 ` Olivier Berger
2009-05-14 17:14               ` Len Brown
2009-05-17  7:38                 ` Olivier Berger
2009-05-22  5:52                   ` Olivier Berger
2009-05-14 17:18     ` Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200904271218.02906.trenn@suse.de \
    --to=trenn@suse.de \
    --cc=linux-acpi@vger.kernel.org \
    --cc=oberger@ouvaton.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox