Re: [PATCH] x86/pci: do assign root bus res if _CRS is used

Gary Hade
2009-05-21T16:37:37Z

On Thu, May 21, 2009 at 08:46:17AM -0600, Bjorn Helgaas wrote:
> On Wednesday 20 May 2009 5:49:10 pm Jesse Barnes wrote:
> > On Fri, 8 May 2009 16:40:10 -0600
> > Bjorn Helgaas <bjorn.helgaas@hp.com> wrote:
> > > Did anything happen with this?
> > >
> > > The longer we wait to make "use_crs" the default, the harder it
> > > will be, so I'd like to push ahead.
> >
> > Here's a patch to make CRS the default. If it looks ok I can push it
> > into my linux-next branch. I'm all for using reliable data from the
> > BIOS. I guess we'll find out fairly quickly if this stuff isn't...
>
> Thanks for following up on this, Jesse. It was on my to-do list for
> yesterday, but I didn't get to it.
>
> Yinghai mentioned a specific box where we might have trouble, but we
> never got enough details to really debug it. So I think we might as
> well give it a shot and fine-tune it as we need to.

I just remembered that Andrew Morton once raised some concerns
related to the number of _CRS returned resources exceeding the
fixed resource array size -> http://lkml.org/lkml/2007/11/1/49

I believe PCI_BUS_NUM_RESOURCES was later increased but if
that increase was insufficient to cover all systems that the
code will now be exposed to, it seems like the "And should we
really be silently ignoring this problem? Should we at least
report it?" comment that was not addressed could become relevent.

Gary

--
Gary Hade
System x Enablement
IBM Linux Technology Center
503-578-4503 IBM T/L: 775-4503
garyhade@us.ibm.com