From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Vladimir Zajac <eightgraph@gmail.com>
Cc: rui.zhang@intel.com, linux-acpi@vger.kernel.org
Subject: Re: PROBLEM: (regression) thermal zone - fan is turned on at higher temperature than it should
Date: Sun, 10 May 2009 03:26:09 +0100 [thread overview]
Message-ID: <20090510022609.GB14018@srcf.ucam.org> (raw)
In-Reply-To: <200905052105.07316.eightgraph@gmail.com>
On Tue, May 05, 2009 at 09:05:07PM +0200, Vladimir Zajac wrote:
> --- linux-2.6.30-rc4/drivers/thermal/thermal_sys.c 2009-04-30 23:52:59.000000000 +0200
> +++ linux-2.6.30-rc4-p1/drivers/thermal/thermal_sys.c 2009-05-04 19:58:30.000000000 +0200
> @@ -961,7 +961,7 @@ void thermal_zone_device_update(struct t
>
> switch (trip_type) {
> case THERMAL_TRIP_CRITICAL:
> - if (temp > trip_temp) {
> + if (temp >= trip_temp) {
> if (tz->ops->notify)
> ret = tz->ops->notify(tz, count,
> trip_type);
> @@ -974,7 +974,7 @@ void thermal_zone_device_update(struct t
> }
> break;
> case THERMAL_TRIP_HOT:
> - if (temp > trip_temp)
> + if (temp >= trip_temp)
> if (tz->ops->notify)
> tz->ops->notify(tz, count, trip_type);
> break;
> @@ -986,14 +986,14 @@ void thermal_zone_device_update(struct t
>
> cdev = instance->cdev;
>
> - if (temp > trip_temp)
> + if (temp >= trip_temp)
> cdev->ops->set_cur_state(cdev, 1);
> else
> cdev->ops->set_cur_state(cdev, 0);
> }
> break;
> case THERMAL_TRIP_PASSIVE:
> - if (temp > trip_temp || tz->passive)
> + if (temp >= trip_temp || tz->passive)
> thermal_zone_device_passive(tz, temp,
> trip_temp, count);
> break;
Looks good. You probably need to resend it with a Signed-off-by: line,
but feel free to add
Acked-by: Matthew Garrett <mjg@redhat.com>
--
Matthew Garrett | mjg59@srcf.ucam.org
prev parent reply other threads:[~2009-05-10 2:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-05 19:05 PROBLEM: (regression) thermal zone - fan is turned on at higher temperature than it should Vladimir Zajac
2009-05-06 0:46 ` yakui_zhao
2009-05-06 5:50 ` Vladimir Zajac
2009-05-06 0:59 ` Zhang Rui
2009-05-10 2:26 ` Matthew Garrett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090510022609.GB14018@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=eightgraph@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox