From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Rafi Rubin <rafi@seas.upenn.edu>
Cc: linux-acpi@vger.kernel.org
Subject: Re: [PATCH] dell-wmi Switch support and Tablet switch definition
Date: Fri, 19 Jun 2009 20:40:09 +0100 [thread overview]
Message-ID: <20090619194009.GA28382@srcf.ucam.org> (raw)
In-Reply-To: <4A3BE6F0.7090107@seas.upenn.edu>
On Fri, Jun 19, 2009 at 03:28:48PM -0400, Rafi Rubin wrote:
> I agree polling the tablet state would be a good thing. But that does not mean we should not
> support the signals until we are ready to support polling.
>
> If you are suggesting that we should not use an EV_SW because we will eventually poll the hardware
> instead of keeping the state in software, then I have no problem with sending keys or other events.
No, my point is that there's little benefit in providing EV_SW if the
initial value is going to be wrong. Software simply can't depend on it.
The code's absolutely fine, but there's a risk that it'll break
otherwise working desktops until we know how to set the initial value.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2009-06-19 19:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-19 11:15 [PATCH] dell-wmi Switch support and Tablet switch definition Rafi Rubin
2009-06-19 14:02 ` Matthew Garrett
2009-06-19 19:28 ` Rafi Rubin
2009-06-19 19:40 ` Matthew Garrett [this message]
2009-06-19 20:31 ` Rafi Rubin
2009-06-19 20:34 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090619194009.GA28382@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rafi@seas.upenn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox