From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Bob Moore <robert.moore@intel.com>, Len Brown <lenb@kernel.org>
Cc: Zhao Yakui <yakui.zhao@intel.com>, linux-acpi@vger.kernel.org
Subject: [PATCH 3/3] ACPI: remove clearing of events on resume, now that ACPI CA does it
Date: Fri, 19 Jun 2009 14:58:02 -0600 [thread overview]
Message-ID: <20090619205802.30130.60093.stgit@bob.kio> (raw)
In-Reply-To: <20090619205713.30130.79530.stgit@bob.kio>
The ACPI CA now clears GPEs and power button events in
acpi_leave_sleep_state_prep(), so there's no need for us to do it again.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
CC: Zhao Yakui <yakui.zhao@intel.com>
---
drivers/acpi/sleep.c | 14 --------------
1 files changed, 0 insertions(+), 14 deletions(-)
diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c
index 01574a0..bf2e2e1 100644
--- a/drivers/acpi/sleep.c
+++ b/drivers/acpi/sleep.c
@@ -257,20 +257,6 @@ static int acpi_suspend_enter(suspend_state_t pm_state)
/* Reprogram control registers and execute _BFS */
acpi_leave_sleep_state_prep(acpi_state);
- /* ACPI 3.0 specs (P62) says that it's the responsibility
- * of the OSPM to clear the status bit [ implying that the
- * POWER_BUTTON event should not reach userspace ]
- */
- if (ACPI_SUCCESS(status) && (acpi_state == ACPI_STATE_S3))
- acpi_clear_event(ACPI_EVENT_POWER_BUTTON);
-
- /*
- * Disable and clear GPE status before interrupt is enabled. Some GPEs
- * (like wakeup GPE) haven't handler, this can avoid such GPE misfire.
- * acpi_leave_sleep_state will reenable specific GPEs later
- */
- acpi_disable_all_gpes();
-
local_irq_restore(flags);
printk(KERN_DEBUG "Back to C!\n");
next prev parent reply other threads:[~2009-06-19 20:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-19 20:57 [PATCH 0/3] ACPICA/ACPI: clean up power button event management during resume Bjorn Helgaas
2009-06-19 20:57 ` [PATCH 1/3] ACPICA: Use fixed event wrappers to enable/disable/clear Bjorn Helgaas
2009-06-19 20:57 ` [PATCH 2/3] ACPICA: Clear GPEs and power button events during wakeup Bjorn Helgaas
2009-06-19 20:58 ` Bjorn Helgaas [this message]
2009-06-20 5:06 ` [PATCH 0/3] ACPICA/ACPI: clean up power button event management during resume Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090619205802.30130.60093.stgit@bob.kio \
--to=bjorn.helgaas@hp.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=robert.moore@intel.com \
--cc=yakui.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox