From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH, v3] eeepc-laptop: Fix build failure with HOTPLUG_PCI && !SYSFS (was: [git pull request] ACPI & driver patches for 2.6.31-rc1) Date: Mon, 29 Jun 2009 21:34:06 +0200 Message-ID: <20090629193406.GA30774@elte.hu> References: <20090629080754.GA28336@elte.hu> <20090629081016.GA31398@elte.hu> <20090629081339.GA321@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Len Brown , Vegard Nossum , Steven Rostedt , "H. Peter Anvin" , Sam Ravnborg Cc: Corentin Chary , Randy Dunlap , Matthew Garrett , Linus Torvalds , Andrew Morton , Linux Kernel Mailing List , linux-acpi@vger.kernel.org List-Id: linux-acpi@vger.kernel.org * Len Brown wrote: > Thanks for fixing this config, Ingo. > > I agree, our build system can handle "depends", > but "select" does not deliver on what it advertises, > making it a trap for programmers. Hm, this portion of Kconfig is a trap in a way indeed - on the other hand it is also a useful tool and the simplistic approach to disallow select altogether is a step backwards. IIRC either Vegard or Steve has come up with a patch series that improved Kconfig to warn about problem selects while still allowing the simple ones. That would deflect most of the bad uses while still allowing the good uses. Not sure what happened to that series. Ingo