linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Renninger <trenn@suse.de>
To: Lin Ming <ming.m.lin@intel.com>
Cc: Len Brown <lenb@kernel.org>,
	"Moore, Robert" <robert.moore@intel.com>,
	Zhao Yakui <yakui.zhao@intel.com>,
	linux-acpi <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH] ACPICA: Revert "ACPICA: Remove obsolete acpi_os_validate_address interface"
Date: Wed, 1 Jul 2009 10:56:35 +0200	[thread overview]
Message-ID: <200907011056.36545.trenn@suse.de> (raw)
In-Reply-To: <1246415391.24831.30.camel@minggr.sh.intel.com>

Hi Lin,

thanks for adding me.
This is not "that" sever, but IMO this one should also be submitted
to 2.6.30 stable kernels as it is a riskless revert of a patch
fixing a regression.

On Wednesday 01 July 2009 04:29:51 Lin Ming wrote:
>     Revert "ACPICA: Remove obsolete acpi_os_validate_address interface"
>     
>     This reverts commit f9ca058430333c9a24c5ca926aa445125f88df18.
>     
>     The quick fix of bug 13620 would be to revert the change.
>     http://bugzilla.kernel.org/show_bug.cgi?id=13620
>     
>     Also, see the commit df92e695998e1bc6e426a840eb86d6d1ee87e2a5
>     "ACPI: track opregion names to avoid driver resource conflicts."
>     
>     But there are problems we need to address:
>     
>     1. We need to enhance the mechanism of avoiding driver resource
>     conflicts
>        to base a "resource" on Field definitions instead of Operation Region
>        definitions.
Good idea, this could avoid some false positive detected region conflicts.
>     
>     2. For dynamic region, we need an interface to call when an operation
>     region (field) is deleted,
>        in order to delete it from the resource list.
>     
>     3. If the same region is created and added to resource list over and
>     over again,
>        this is have the potential to be a memory leak by growing the list
>        every time
Region or field or both?
How can this happen, can you show a little ASL snippet or explain this a bit 
more detailed, please. I do not fully understand what is meant in 3.

Thanks,

  Thomas

  reply	other threads:[~2009-07-01  8:56 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-01  2:29 [PATCH] ACPICA: Revert "ACPICA: Remove obsolete acpi_os_validate_address interface" Lin Ming
2009-07-01  8:56 ` Thomas Renninger [this message]
2009-07-01  9:23   ` Lin Ming
2009-07-01  9:35     ` Thomas Renninger
2009-07-01 15:29       ` Moore, Robert
2009-07-01 21:19         ` Thomas Renninger
2009-07-01 22:07           ` Moore, Robert
2009-07-02  8:20             ` Jean Delvare
2009-07-02  8:30           ` Jean Delvare
2009-07-02  2:03 ` Len Brown
2009-07-02  6:27   ` Lin Ming
2009-07-02  6:42     ` Moore, Robert
2009-07-02 10:15       ` Thomas Renninger
2009-07-02 10:12     ` Thomas Renninger
2009-07-03  1:30       ` Lin Ming
2009-07-13 15:36     ` Thomas Renninger
2009-07-14  2:28       ` Lin Ming
2009-07-17 15:02         ` Thomas Renninger
2009-07-02 10:22   ` Thomas Renninger
2009-07-02 15:49     ` Moore, Robert
2009-07-04  1:29       ` Robert Hancock
2009-08-30 13:43         ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200907011056.36545.trenn@suse.de \
    --to=trenn@suse.de \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=ming.m.lin@intel.com \
    --cc=robert.moore@intel.com \
    --cc=yakui.zhao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).