public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>
To: Shaohua Li <shaohua.li@intel.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"lenb@kernel.org" <lenb@kernel.org>,
	"Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>,
	"andi@firstfloor.org" <andi@firstfloor.org>,
	Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH]new ACPI processor driver to force CPUs idle
Date: Mon, 6 Jul 2009 23:33:12 +0530	[thread overview]
Message-ID: <20090706180312.GC26831@dirshya.in.ibm.com> (raw)
In-Reply-To: <20090629025455.GA20614@sli10-desk.sh.intel.com>

* Shaohua Li <shaohua.li@intel.com> [2009-06-29 10:54:55]:

[snip]

> > 
> > How do we handle interrupts and timers during this interval?  You seem
> > to disable interrupts and hold the cpu at idle for 0.95 sec.  It may
> > cause timeouts and overflows for network interrupts right?
> The x86 mwait/monitor instruction can detect interrupt and complete execution
> even interrupt is disabled, so this isn't an issue.

Cool, this will save a lot of trouble :)
 
> > Next issue is halting sibling threads belonging to a core at the same
> > time to have any power/thermal benefit.  Who does the coordination for
> > forced idle in this approach?
> Nobody does the coordination. Halt some threads even they belong to a core
> is the best we can provide now. For future, if the scheduler approach really
> works, we will happily use it.

Do you have some indicative data to show that arbitrary force-idling
of hardware threads reduce power and heat?  It will be very good if
this works without coordination among siblings.  Basically what you
are saying is that running one or two of the force-idle threads in
a 16-thread system provides significant reduction in power even
without explicit methods to ensure that they idle sibling threads
belonging to same core.

--Vaidy


  reply	other threads:[~2009-07-06 18:03 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-24  4:13 [PATCH]new ACPI processor driver to force CPUs idle Shaohua Li
2009-06-24  6:39 ` Peter Zijlstra
2009-06-24  7:47   ` Shaohua Li
2009-06-24  8:03     ` Peter Zijlstra
2009-06-24  8:21       ` Shaohua Li
2009-06-26 18:16         ` Vaidyanathan Srinivasan
2009-06-29  2:54           ` Shaohua Li
2009-07-06 18:03             ` Vaidyanathan Srinivasan [this message]
2009-07-06 23:43               ` Andi Kleen
2009-07-07  0:50                 ` Pallipadi, Venkatesh
2009-07-10 19:31               ` Len Brown
2009-06-24 17:20       ` Len Brown
2009-06-26  7:46         ` Peter Zijlstra
2009-06-26 16:46           ` Len Brown
2009-06-26 18:42             ` Vaidyanathan Srinivasan
2009-07-10 19:47               ` Len Brown
2009-06-26 19:49             ` Matthew Garrett
2009-07-10 20:29               ` Len Brown
2009-06-30  8:02             ` Shaohua Li
2009-07-07  8:26               ` Peter Zijlstra
2009-07-07  8:24             ` Peter Zijlstra
2009-07-10 20:41               ` Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090706180312.GC26831@dirshya.in.ibm.com \
    --to=svaidy@linux.vnet.ibm.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=andi@firstfloor.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=shaohua.li@intel.com \
    --cc=tglx@linutronix.de \
    --cc=venkatesh.pallipadi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox