From: Ingo Molnar <mingo@elte.hu>
To: Len Brown <lenb@kernel.org>
Cc: x86@kernel.org, sfi-devel@simplefirmware.org,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
Feng Tang <feng.tang@intel.com>, Len Brown <len.brown@intel.com>
Subject: Re: [PATCH 02/12] SFI, x86: add CONFIG_SFI
Date: Fri, 10 Jul 2009 07:23:06 +0200 [thread overview]
Message-ID: <20090710052306.GC22218@elte.hu> (raw)
In-Reply-To: <d5a8e3203627c313e8fdbf4fa9ac1cb1cdc6706c.1247025117.git.len.brown@intel.com>
* Len Brown <lenb@kernel.org> wrote:
> +++ b/drivers/sfi/Kconfig
> @@ -0,0 +1,16 @@
> +#
> +# SFI Configuration
> +#
> +
> +menuconfig SFI
> + bool "SFI (Simple Firmware Interface) Support"
> + depends on X86
Instead of 'depends on X86' it's cleaner to add a HAVE_ARCH_SFI
Kconfig variable to arch/x86/Kconfig, and turn the above into:
depends on HAVE_ARCH_SFI
That will make it easier to enable it on other architectures such as
IA64, should the need arise - and it's cleaner in any case.
> + default n
Kconfig uses 'default n' by default, so this line can be left out.
> + ---help---
> + The Simple Firmware Interface (SFI) provides a lightweight method
> + for platform firmware to pass information to the Operating System
> + via static tables in memory.
> +
> + For more information, see http://simplefirmware.org
> +
> + Say 'Y' here to enable the kernel to boot on SFI-only platforms.
Nitpick: s/Operating System/Linux kernel
(and even if we want to formulate it in a general way, it should be
'operating system')
Ingo
next prev parent reply other threads:[~2009-07-10 5:23 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-08 4:13 [PATCH v2 for 2.6.32] SFI - Simple Firmware Interface support Len Brown
2009-07-08 4:13 ` [PATCH 01/12] SFI: Simple Firmware Interface - new MAINTAINERS entry Len Brown
2009-07-08 4:13 ` [PATCH 02/12] SFI, x86: add CONFIG_SFI Len Brown
2009-07-10 5:23 ` Ingo Molnar [this message]
2009-07-08 4:13 ` [PATCH 03/12] SFI: document boot param "sfi=off" Len Brown
2009-07-28 19:24 ` Bjorn Helgaas
2009-07-28 19:52 ` Len Brown
2009-07-08 4:13 ` [PATCH 04/12] SFI: create include/linux/sfi.h Len Brown
2009-07-10 6:48 ` Ingo Molnar
2009-07-08 4:13 ` [PATCH 05/12] SFI: add core support Len Brown
2009-07-10 7:40 ` Ingo Molnar
2009-07-08 4:13 ` [PATCH 06/12] ACPI, x86: remove ACPI dependency on some IO-APIC routines Len Brown
2009-07-10 6:51 ` Ingo Molnar
2009-07-08 4:13 ` [PATCH 07/12] SFI: add x86 support Len Brown
2009-07-10 6:37 ` Ingo Molnar
2009-07-10 6:48 ` Feng Tang
2009-07-08 4:13 ` [PATCH 08/12] SFI, x86: hook e820() for memory map initialization Len Brown
2009-07-08 21:37 ` H. Peter Anvin
2009-07-09 1:11 ` Feng Tang
2009-07-09 3:57 ` H. Peter Anvin
2009-07-08 4:13 ` [PATCH 09/12] SFI: Enable SFI to parse ACPI tables Len Brown
2009-07-10 6:10 ` Ingo Molnar
2009-07-08 4:13 ` [PATCH 10/12] ACPI: check acpi_disabled in acpi_table_parse() Len Brown
2009-07-08 4:13 ` [PATCH 11/12] SFI, PCI: Hook MMCONFIG Len Brown
2009-07-10 5:52 ` Ingo Molnar
2009-07-10 7:17 ` Feng Tang
2009-07-10 11:14 ` Ingo Molnar
2009-07-08 4:13 ` [PATCH 12/12] SFI: add boot-time initialization hooks Len Brown
2009-07-10 5:18 ` [PATCH v2 for 2.6.32] SFI - Simple Firmware Interface support Ingo Molnar
2009-07-11 1:01 ` Len Brown
2009-07-11 8:26 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090710052306.GC22218@elte.hu \
--to=mingo@elte.hu \
--cc=feng.tang@intel.com \
--cc=len.brown@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfi-devel@simplefirmware.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).