Re: [PATCH] ACPI: add driver for SMBus Control Method Interface

ykzhao
2009-07-16T00:45:34Z

On Wed, 2009-07-15 at 22:00 +0800, Matthew Garrett wrote:
> On Wed, Jul 15, 2009 at 05:43:22PM +0800, ykzhao wrote:
> > On Wed, 2009-07-15 at 14:02 +0800, Crane Cai wrote:
> > > This driver supports the SMBus Control Method Interface. It needs BIOS declare
> > > ACPI control methods via SMBus Control Method Interface Spec.
> > It seems that SM bus control is realized in BIOS. And OS can use the
> > given control method interface to access it.
> > Will this controller be accessed directly directly BIOS?
> > If it can be accessed by BIOS, how to resolve the conflict between BIOS
> > and OS?
>
> It's being accessed via ACPI methods, so the vendors have the
> opportunity to implement proper locking.
If the vendors can implement the proper locking, there will be no
conflict.

Another issue is that this driver had better be put in the directory of
driver/platform/x86/.
Thanks.
>
> > In fact we see the conflict on some boxes. The SMbus controller will be
> > accessed by BIOS. If the corresponding driver is loaded for the SMBUS
> > controller, there exists the potential risk. In such case we will hide
> > the SMbus controller or not load the device driver for it.
>
> I don't think that's a risk in this case.
>