From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: intel-gfx@lists.freedesktop.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH 3/4] drm/i915: use ACPI LID status for LVDS ->detect hook
Date: Wed, 15 Jul 2009 16:09:01 -0700 [thread overview]
Message-ID: <20090715160901.6407eb65@jbarnes-g45> (raw)
In-Reply-To: <20090715225558.GC31194@srcf.ucam.org>
On Wed, 15 Jul 2009 23:55:58 +0100
Matthew Garrett <mjg59@srcf.ucam.org> wrote:
> On Wed, Jul 15, 2009 at 03:11:25PM -0700, Jesse Barnes wrote:
> > We can't load or hotplug detect LVDS like we can other outputs, but
> > if there's a lid device present we can use it as a proxy. This
> > allows the LFP state to be determined at ->detect time, making
> > configurations requiring manual intervention today "just work"
> > assuming the lid device status is correct.
>
> I'm a bit unhappy with this appearing to be generic functionality but
> ending up implemented in the driver rather than in the KMS core. If
> this is going in then can we at least document this behaviour and
> that other KMS drivers are expected to implement it?
Well, we don't really have generic LVDS helpers where we could put
this, but yeah we can document this as preferred for all LVDS outputs.
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2009-07-15 23:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-15 22:11 drm/i915: LVDS lid patches Jesse Barnes
2009-07-15 22:11 ` [PATCH 1/4] ACPI button: provide lid status functions Jesse Barnes
2009-07-15 22:48 ` Matthew Garrett
2009-07-15 22:54 ` Jesse Barnes
2009-07-16 1:16 ` [Intel-gfx] " ykzhao
2009-07-15 22:11 ` [PATCH 2/4] drm/i915: force mode set at lid open time Jesse Barnes
2009-07-15 22:54 ` Matthew Garrett
2009-07-16 1:36 ` [Intel-gfx] " ykzhao
2009-07-16 16:30 ` Jesse Barnes
2009-07-17 1:34 ` ykzhao
2009-07-17 16:33 ` Jesse Barnes
2009-07-15 22:11 ` [PATCH 3/4] drm/i915: use ACPI LID status for LVDS ->detect hook Jesse Barnes
2009-07-15 22:55 ` Matthew Garrett
2009-07-15 23:09 ` Jesse Barnes [this message]
2009-07-16 1:54 ` [Intel-gfx] " ykzhao
2009-07-16 16:32 ` Jesse Barnes
2009-07-17 1:44 ` ykzhao
2009-07-15 22:11 ` [PATCH 4/4] drm/i915: generate a KMS uevent at lid open/close time Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090715160901.6407eb65@jbarnes-g45 \
--to=jbarnes@virtuousgeek.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-acpi@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox