Re: [Intel-gfx] [PATCH 2/4] drm/i915: force mode set at lid open time

[Jesse Barnes <jbarnes@virtuousgeek.org>]

On Thu, 16 Jul 2009 09:36:13 +0800
ykzhao <yakui.zhao@intel.com> wrote:

> On Thu, 2009-07-16 at 06:11 +0800, Jesse Barnes wrote:
> > Some laptop platforms will disable pipes and/or planes at lid close
> > time and not restore them when the lid is opened again.  So catch
> > the lid event, and if the lid was opened, force a mode restore.
> Why is it necessary to force a mode restore when the LID is reopened?
> Do you mean that the pipes/planes are disabled automatically by BIOS
> when the LID is closed? 

Yes, maybe I need to make that clearer in the changelog.

> If so, maybe it will be better that this feature is limited to some
> boxes. It is unnecessary to add this feature for all the laptops.

The downside of doing that is that we'll always be playing catch up,
adding quirks for machines as problems are discovered, as opposed to
everything "just working" out of the box.  A whitelist might be better,
but really forcing a mode set at open isn't expensive, and with some
care in our mode setting routines, need not flicker at all.

> Is it enough to mark the LVDS as disconnected/connected according to
> the LID status? And this is done by user-space tool.

Not sure what you mean here...

> > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
> > index 39b393d..5873865 100644
> > --- a/drivers/gpu/drm/Kconfig
> > +++ b/drivers/gpu/drm/Kconfig
> > @@ -86,6 +86,7 @@ config DRM_I915
> >  	select FB_CFB_COPYAREA
> >  	select FB_CFB_IMAGEBLIT
> >  	select FB
> > +	select ACPI_BUTTON
> How about 
>   +	  select ACPI_BUTTON if ACPI

Yeah I saw your other comments too about non-ACPI configs.  I have a
hard time caring about them though; so much depends on ACPI these days
that disabling it is just a bad idea.  But I guess it's not too much
trouble to make this work w/o.

Thanks,
-- 
Jesse Barnes, Intel Open Source Technology Center