* Re: [PATCH] laptop_panel.brightness_in_hardware: add all Asus laptops [not found] ` <20090708104300.GA10269@srcf.ucam.org> @ 2009-07-16 22:22 ` Alan Jenkins 2009-07-16 22:27 ` Matthew Garrett 0 siblings, 1 reply; 2+ messages in thread From: Alan Jenkins @ 2009-07-16 22:22 UTC (permalink / raw) To: Matthew Garrett; +Cc: hal, Corentin Chary, linux acpi Matthew Garrett wrote: > The problem in that case is that the kernel changes the backlight for > us. The lack of consistency on this front makes life somewhat harder. > > In terms of the "Some hardware sends keyboard events but also changes > the brightness", I'm working on a cleaner solution for this. The easiest > would seem to be to generate a uevent when the backlight is changed, > which would then allow userspace to pop up UI even though the key press > events aren't propagated. It would seem to deal with the Eee (and older > Thinkpad) cases quite nicely, but does require some more code in > userspace. > Ok. Maybe it's trivial or "niche", but I really appreciate this. I think it's the only remaining issue I have with my EeePC :-). I just saw the patch to generate uevents for the acpi video driver. It looks like it still generates KEY_BRIGHTNESSDOWN. Are you planning a followup patch, to suppress the input events when brightness_switch_enabled == 1? Equally, w.r.t patch 3, I don't think eeepc-laptop, should generate brightness events on the *input* device anymore. The rationale is that KEY_BRIGHTNESSDOWN is a user request to increase brightness. In these cases, the firmware/driver has already increased the brightness. We've notified userspace via the backlight device. So we shouldn't pass the request on to userspace; it has already been acted upon. If we still generate KEY_BRIGHTNESS*, userspace has to guess whether or not the change has already been applied. If there is too much latency, it guesses wrong :-(. Thanks! Alan ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] laptop_panel.brightness_in_hardware: add all Asus laptops 2009-07-16 22:22 ` [PATCH] laptop_panel.brightness_in_hardware: add all Asus laptops Alan Jenkins @ 2009-07-16 22:27 ` Matthew Garrett 0 siblings, 0 replies; 2+ messages in thread From: Matthew Garrett @ 2009-07-16 22:27 UTC (permalink / raw) To: Alan Jenkins; +Cc: hal, Corentin Chary, linux acpi On Thu, Jul 16, 2009 at 11:22:47PM +0100, Alan Jenkins wrote: > I just saw the patch to generate uevents for the acpi video driver. It > looks like it still generates KEY_BRIGHTNESSDOWN. Are you planning a > followup patch, to suppress the input events when > brightness_switch_enabled == 1? I didn't want to change the behaviour of the driver with existing userspace, but yes, I agree that that's the correct behaviour. To make it consistent with everything else it should probably also default to brightness_switch_enabled = 0 (and we ship it that way in Fedora), but again, compatibility. > Equally, w.r.t patch 3, I don't think eeepc-laptop, should generate > brightness events on the *input* device anymore. Right. > The rationale is that KEY_BRIGHTNESSDOWN is a user request to increase > brightness. In these cases, the firmware/driver has already increased > the brightness. We've notified userspace via the backlight device. So we > shouldn't pass the request on to userspace; it has already been acted > upon. If we still generate KEY_BRIGHTNESS*, userspace has to guess > whether or not the change has already been applied. If there is too much > latency, it guesses wrong :-(. Absolutely. The other thing that needs doing is for dell-laptop to consume the brightness keys, or alternatively for us to remap them on Dells. Right now (in the worst case) we're getting two sets of them. -- Matthew Garrett | mjg59@srcf.ucam.org ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-07-16 22:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <4A49D305.1040703@tuffmail.co.uk>
[not found] ` <71cd59b00906300231yf2d3657tb5c5945f5aae0e7b@mail.gmail.com>
[not found] ` <20090708095111.GA8471@srcf.ucam.org>
[not found] ` <61b223ba0907080336i313232cco216c9c647a2e9247@mail.gmail.com>
[not found] ` <20090708104300.GA10269@srcf.ucam.org>
2009-07-16 22:22 ` [PATCH] laptop_panel.brightness_in_hardware: add all Asus laptops Alan Jenkins
2009-07-16 22:27 ` Matthew Garrett
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox