Re: [PATCH] powernow-k8: don't load powernow-k8 driver when acpi=off

[Thomas Renninger <trenn@suse.de>]

On Thursday 23 July 2009 04:11:10 Zhang Rui wrote:
> when acpi=off, powernow-k8 driver is still loaded, and fails with
> a firmware bug warning message.
> http://bugzilla.kernel.org/show_bug.cgi?id=13695#c5

Powernow-k8 can theoretically fetch info from a non-acpi
table for specific 1 core systems, but I agree that in nearly
all cases this won't work anyway. And acpi should still
be switched on.

Mark should get a chance to look at this before it's submitted,
though.

> this is misleading,
> we should not load powernow-k8 driver when acpi=off.
> http://bugzilla.kernel.org/show_bug.cgi?id=13695
> 
> Signed-off-by: Zhang Rui <rui.zhang@intel.com>

Reviewed-by: Thomas Renninger <trenn@suse.de>

> Tested-by: David Santamaría Rogado <howl.nsp@gmail.com>
> ---
>  arch/x86/kernel/cpu/cpufreq/powernow-k8.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> Index: linux-2.6/arch/x86/kernel/cpu/cpufreq/powernow-k8.c
> ===================================================================
> --- linux-2.6.orig/arch/x86/kernel/cpu/cpufreq/powernow-k8.c
> +++ linux-2.6/arch/x86/kernel/cpu/cpufreq/powernow-k8.c
> @@ -1436,6 +1436,9 @@ static int __cpuinit powernowk8_init(voi
>  {
>  	unsigned int i, supported_cpus = 0;
>  
> +	if (acpi_disabled)
> +		return 0;
> +
>  	for_each_online_cpu(i) {
>  		int rc;
>  		smp_call_function_single(i, check_supported_cpu, &rc, 1);
> 
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html