From: Feng Tang <feng.tang@intel.com>
To: Alexander Beregalov <a.beregalov@gmail.com>
Cc: Len Brown <lenb@kernel.org>,
linux-next <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: next: sfi build fails when !CONFIG_ACPI
Date: Thu, 23 Jul 2009 18:15:25 +0800 [thread overview]
Message-ID: <20090723181525.475692d3@feng-desktop> (raw)
In-Reply-To: <a4423d670907230143l78f324dewefa4cb8990ef4266@mail.gmail.com>
On Thu, 23 Jul 2009 16:43:30 +0800
Alexander Beregalov <a.beregalov@gmail.com> wrote:
> 2009/7/17 Alexander Beregalov <a.beregalov@gmail.com>:
> > 2009/7/17 Len Brown <lenb@kernel.org>:
> >>> drivers/sfi/sfi_core.c: In function 'sfi_init':
> >>> drivers/sfi/sfi_core.c:346: error: 'acpi_disabled' undeclared
> >>> (first use in this function)
> >>> drivers/sfi/sfi_core.c:346: error: (Each undeclared identifier is
> >>> reported only once
> >>> drivers/sfi/sfi_core.c:346: error: for each function it appears
> >>> in.)
> >>>
> >>>
> >>> $ grep ACPI .config
> >>> # Power management and ACPI options
> >>
> >> It builds for me.
> >> Please send me the complete failing .config
> >
> > Attached (x86_64)
>
> Still fails for me in the same way,
> X86_64
> next-20090723
sorry for the late response, please try the following patch:
diff --git a/drivers/sfi/sfi_core.c b/drivers/sfi/sfi_core.c
index 62e2f98..fa66824 100644
--- a/drivers/sfi/sfi_core.c
+++ b/drivers/sfi/sfi_core.c
@@ -361,9 +361,6 @@ static __init int sfi_find_syst(void)
void __init sfi_init(void)
{
- if (!acpi_disabled)
- disable_sfi();
-
if (sfi_disabled)
return;
Thanks,
Feng
next prev parent reply other threads:[~2009-07-23 10:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-16 8:48 next: sfi build fails when !CONFIG_ACPI Alexander Beregalov
2009-07-17 1:46 ` Len Brown
2009-07-17 13:57 ` Alexander Beregalov
2009-07-23 8:43 ` Alexander Beregalov
2009-07-23 10:15 ` Feng Tang [this message]
2009-07-23 11:28 ` Alexander Beregalov
2009-07-22 22:06 ` Randy Dunlap
2009-07-23 8:33 ` Feng Tang
2009-07-23 14:53 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090723181525.475692d3@feng-desktop \
--to=feng.tang@intel.com \
--cc=a.beregalov@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).