From: Frans Pop <elendil@planet.nl>
To: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
Cc: mjg@redhat.com, maciej.rutecki@gmail.com,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hp-wmi: improve rfkill support
Date: Thu, 23 Jul 2009 21:28:18 +0200 [thread overview]
Message-ID: <200907232128.19735.elendil@planet.nl> (raw)
In-Reply-To: <4A65A2F9.1060509@tuffmail.co.uk>
Alan Jenkins wrote:
> 1) Add support for reading the hardware blocked state. Previously
> we read a combination of the hardware and software blocked states,
> reporting it as the software blocked state. This caused some
> confusing behaviour.
>
> 2) The software state is persistent, mark it as such.
>
> 3) Check rfkill in the resume handler. Both the hard and soft
> blocked states may change over hibernation.
I've added this to my local branch for .31 for my HP 2510p.
Light testing (linux only) showed no problems with .31-rc4.
One question: is it expected that pressing the hardware kill switch only
enables the block for phy0? I guess it's probably sufficient.
$ ./rfkill list # after pressing hardware switch
0: phy0: Wireless LAN
Soft blocked: no
Hard blocked: yes
1: hp-wifi: Wireless LAN
Soft blocked: no
Hard blocked: no
2: hp-bluetooth: Bluetooth
Soft blocked: no
Hard blocked: no
Looks like with bluetooth soft-blocked the wireless leds blink on wifi
network traffic, while with bluetooth unblocked it stays on permanently.
Cheers,
FJP
next prev parent reply other threads:[~2009-07-23 19:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-21 11:14 [PATCH] hp-wmi: improve rfkill support Alan Jenkins
2009-07-21 11:26 ` Matthew Garrett
2009-07-23 15:31 ` Maciej Rutecki
2009-07-23 18:27 ` Alan Jenkins
2009-07-23 19:36 ` Maciej Rutecki
2009-07-23 19:28 ` Frans Pop [this message]
2009-12-10 4:53 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907232128.19735.elendil@planet.nl \
--to=elendil@planet.nl \
--cc=alan-jenkins@tuffmail.co.uk \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.rutecki@gmail.com \
--cc=mjg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).