From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Jonathan Woithe <jwoithe@physics.adelaide.edu.au>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
Dan Carpenter <error27@gmail.com>,
corbet@lwn.net, eteo@redhat.com, Julia Lawall <julia@diku.dk>
Subject: Re: [PATCH] fujitsu-laptop: remove superfluous NULL pointer checks
Date: Thu, 30 Jul 2009 13:12:47 +0200 [thread overview]
Message-ID: <200907301312.48132.bzolnier@gmail.com> (raw)
In-Reply-To: <200907300743.n6U7hnK6000821@mercury.physics.adelaide.edu.au>
Hi,
On Thursday 30 July 2009 09:43:49 Jonathan Woithe wrote:
> Hi Bart
>
> > From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> > Subject: [PATCH] fujitsu-laptop: remove superfluous NULL pointer checks
> >
> > This takes care of the following entries from Dan's list:
> >
> > drivers/platform/x86/fujitsu-laptop.c +327 set_lcd_level(13) warning: variable derefenced before check 'fujitsu'
> > drivers/platform/x86/fujitsu-laptop.c +358 set_lcd_level_alt(13) warning: variable derefenced before check 'fujitsu'
>
> I'd rather keep the test for a non-null fujitsu in there, but obviously it's
> kind of pointless doing it after the first dereference. Since this fixup
> overlaps with the one previously discussed with Julia I've taken the liberty
They are on top of Julia's patch (sorry I forgot to mention it)..
next prev parent reply other threads:[~2009-07-30 12:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-29 20:14 [PATCH] fujitsu-laptop: remove superfluous NULL pointer checks Bartlomiej Zolnierkiewicz
2009-07-30 7:43 ` Jonathan Woithe
2009-07-30 11:12 ` Bartlomiej Zolnierkiewicz [this message]
2009-07-31 3:57 ` Jonathan Woithe
2009-07-30 7:55 ` [PATCH] fujitsu-laptop: consolidated fixes (NULL pointer checks, [un]registration fixes, etc) Jonathan Woithe
2009-07-30 12:08 ` Bartlomiej Zolnierkiewicz
2009-07-31 4:04 ` Jonathan Woithe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907301312.48132.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=corbet@lwn.net \
--cc=error27@gmail.com \
--cc=eteo@redhat.com \
--cc=julia@diku.dk \
--cc=jwoithe@physics.adelaide.edu.au \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox