Re: [PATCH] fujitsu-laptop: remove superfluous NULL pointer checks

Jonathan Woithe
2009-07-31T03:57:45Z

Hi

> > > From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> > > Subject: [PATCH] fujitsu-laptop: remove superfluous NULL pointer checks
> > >
> > > This takes care of the following entries from Dan's list:
> > >
> > > drivers/platform/x86/fujitsu-laptop.c +327 set_lcd_level(13) warning: variable derefenced before check 'fujitsu'
> > > drivers/platform/x86/fujitsu-laptop.c +358 set_lcd_level_alt(13) warning: variable derefenced before check 'fujitsu'
> >
> > I'd rather keep the test for a non-null fujitsu in there, but obviously it's
> > kind of pointless doing it after the first dereference. Since this fixup
> > overlaps with the one previously discussed with Julia I've taken the liberty
>
> They are on top of Julia's patch (sorry I forgot to mention it)..

Ah, right. I was trying to work out where it fitted (that was probably the
one preceeding patch I *didn't* end up trying).

Regards
jonathan