public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Corentin Chary <corentin.chary@gmail.com>
To: Danny Kukawka <danny.kukawka@web.de>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>,
	acpi4asus-user@lists.sourceforge.net,
	Alan Jenkins <sourcejedi.lkml@googlemail.com>,
	hal@lists.freedesktop.org,
	linux acpi <linux-acpi@vger.kernel.org>
Subject: Re: Illuminated keyboard on ASUS U50VG laptop, backlight or led ?
Date: Thu, 6 Aug 2009 12:07:12 +0200	[thread overview]
Message-ID: <200908061207.12450.corentin.chary@gmail.com> (raw)
In-Reply-To: <71cd59b00908020020p1f672529mf3cd403526005ed5@mail.gmail.com>

On Sunday 02 August 2009 09:20:00 Corentin Chary wrote:
> >> see:
> >> http://cgit.freedesktop.org/~dkukawka/hal/commit/?id=c900d0e5012b1dd0e0f
> >>a6e20fd0d92a59b3de093
>
> It's not my hardware either, but I can try to create a fake
> kbd_keyboard led to test that.
>
> > Don't you also need to set "keyboard_backlight.num_levels"?  According
> > to Documentation/leds-class.txt, valid led values are 0-255, so I
> > expect num_levels should be set to 256.
>
> Valid led values are between 0 and max_brightness (like for backlight I
> think). I think the led addon should set keyboard_backlight.num_levels to
> max_brightness (+1 ?).
>
> > Yuck... I think the backlight interface is better in that it exports
> > the available granularity.  But I guess all one really wants is "on"
> > and "off", with finer adjustment being either automatic (light sensor)
> > or buried as a config option.
>
> On the Asus U50 there is 3 levels (+ off), and keys to change the
> brightness. And the user want to use all the backlight levels with the
> Fn+F3/F4 keys.

Hi Danny,
I was trying to add keyboard_backlight.num_levels support for your modified 
led-addon. But there is something I don't understand :- 
keyboard_backlight.num_levels is used in:
- examples/light_sensors_and_keyboard_backlight.py
- fdi/policy/10osvendor/10-macbookpro-utils.fdi
- kde/solid/hal/halpower.cpp
But it is not defined in doc/spec/hal-spec-properties.xml.

Should I make another patch to fix hal-spec-properties ?

Thanks,

-- 
Corentin Chary
http://xf.iksaif.net - http://uffs.org

  reply	other threads:[~2009-08-06 10:07 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-24  7:34 Illuminated keyboard on ASUS U50VG laptop, backlight or led ? Corentin Chary
2009-07-28 19:51 ` Corentin Chary
2009-07-28 20:04   ` Matthew Garrett
2009-08-01 10:40     ` Corentin Chary
2009-08-01 11:19       ` Alan Jenkins
2009-08-01 12:40         ` Corentin Chary
2009-08-01 13:21           ` Danny Kukawka
2009-08-01 15:50             ` Corentin Chary
2009-08-01 16:30               ` Alan Jenkins
2009-08-01 17:21                 ` Danny Kukawka
2009-08-01 19:43                   ` Alan Jenkins
2009-08-01 19:47                     ` Alan Jenkins
2009-08-02  7:20                     ` Corentin Chary
2009-08-06 10:07                       ` Corentin Chary [this message]
2009-08-06 10:48                         ` Danny Kukawka
2009-08-06 11:59                           ` Corentin Chary
2009-08-06 16:20                             ` Danny Kukawka
2009-08-06 17:00                               ` Corentin Chary
2009-12-07  7:51                               ` Corentin Chary

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200908061207.12450.corentin.chary@gmail.com \
    --to=corentin.chary@gmail.com \
    --cc=acpi4asus-user@lists.sourceforge.net \
    --cc=danny.kukawka@web.de \
    --cc=hal@lists.freedesktop.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=sourcejedi.lkml@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox