Re: [PATCH 1/5] introduce .wakeup_event ops

Rafael J. Wysocki
2009-08-24T18:48:19Z

On Monday 24 August 2009, Shaohua Li wrote:
> On Mon, 2009-08-24 at 16:27 +0800, Matthew Garrett wrote:
> > On Mon, Aug 24, 2009 at 04:21:50PM +0800, Shaohua Li wrote:
> > > On Mon, 2009-08-24 at 16:09 +0800, Matthew Garrett wrote:
> > > > I don't agree - the wakeup GPE will generate a standard notify, and the
> > > > notification handler has to be at the device or bus layer to handle
> > > > device-specific requests.
> > > Then we will have duplicate code at each device or bus.
> >
> > I think that's inevitable, unless the notification infrastructure is
> > made more fine grained.
> At least we need some check and maybe gpe handling and we need some
> "ifdef ACPI" staff at each device or bus.

Why would we need that?

> There isn't big difference device/bus register a notification handler or
> register a .wakeup_event. And .wakeup_event is more simple in device/bus
> level.

As Matthew said, there is.

To make things clear, we're not going to add .wakeup_event().

Thanks,
Rafael