Re: [PATCH 1/5] introduce .wakeup_event ops

Matthew Garrett
2009-08-19T11:52:20Z

On Wed, Aug 19, 2009 at 03:24:11PM +0800, Shaohua Li wrote:

> Usually driver should does nothing in the op as bus can handle it. But in some
> cases, like pci bus, UHCI controller doesn't use standard PME registers for
> wakeup, instead of using special approach. In this case, UHCI controller driver
> should implement this op.

I'm not averse to the general concept, but I'm not entirely sold on it
being necessary. All the hardware I'm aware of will send non-PME events
as a notification on a specific device. Under what circumstances will we
get a wakeup GPE for a non-PME device without knowing which device
should be woken?

--
Matthew Garrett | mjg59@srcf.ucam.org