From: Andrew Morton <akpm@linux-foundation.org>
Cc: djwong@us.ibm.com, lenb@kernel.org, linux-kernel@vger.kernel.org,
lm-sensors@lm-sensors.org, linux-acpi@vger.kernel.org,
rui.zhang@intel.com, pavel@ucw.cz
Subject: Re: [PATCH 2/2] acpi_power_meter: hwmon driver for ACPI 4.0 power meters
Date: Thu, 20 Aug 2009 16:47:41 -0700 [thread overview]
Message-ID: <20090820164741.707b0340.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090818234810.2004.13573.stgit@elm3a70.beaverton.ibm.com>
On Tue, 18 Aug 2009 16:48:10 -0700
"Darrick J. Wong" <djwong@us.ibm.com> wrote:
> This driver exposes ACPI 4.0 compliant power meters as hardware monitoring
> devices. This second revision of the driver also exports the ACPI string
> info as sysfs attributes, a list of the devices that the meter measures,
> and will send ACPI notifications over the ACPI netlink socket.
This is not my favoritest ever patch.
drivers/acpi/power_meter.c:459: error: 'POWER_AVERAGE' undeclared here (not in a function)
and
drivers/acpi/power_meter.c: In function 'read_domain_devices':
drivers/acpi/power_meter.c:544: error: syntax error before 'PREFIX'
drivers/acpi/power_meter.c: In function 'read_capabilities':
drivers/acpi/power_meter.c:759: error: syntax error before 'PREFIX'
drivers/acpi/power_meter.c:776: error: syntax error before 'PREFIX'
and once I fixed those,
drivers/acpi/power_meter.c: In function 'register_ro_attrs':
drivers/acpi/power_meter.c:611: warning: 'res' may be used uninitialized in this function
drivers/acpi/power_meter.c: In function 'register_rw_attrs':
drivers/acpi/power_meter.c:639: warning: 'res' may be used uninitialized in this function
next prev parent reply other threads:[~2009-08-20 23:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-18 23:47 [PATCH 0/2] ACPI 4.0 power meter Darrick J. Wong
2009-08-18 23:48 ` [PATCH 1/2] hwmon: Enhance the sysfs API for power meters Darrick J. Wong
2009-08-18 23:48 ` [PATCH 2/2] acpi_power_meter: hwmon driver for ACPI 4.0 " Darrick J. Wong
2009-08-20 23:47 ` Andrew Morton [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-07-25 0:43 [PATCH 0/2] ACPI 4.0 power meter Darrick J. Wong
2009-07-25 0:43 ` [PATCH 2/2] acpi_power_meter: hwmon driver for ACPI 4.0 power meters Darrick J. Wong
2009-07-27 1:44 ` ykzhao
2009-08-03 20:48 ` Darrick J. Wong
2009-07-27 6:45 ` Zhang Rui
2009-08-03 20:52 ` Darrick J. Wong
2009-07-28 1:25 ` Len Brown
2009-08-03 20:58 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090820164741.707b0340.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=djwong@us.ibm.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=pavel@ucw.cz \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).