[PATCH] acpi: thermal: display forced passive trip points in proc

[PATCH] acpi: thermal: display forced passive trip points in proc

[Frans Pop]

Users can force a passive trip point for a thermal zone that does not
have _PSV defined in ACPI by setting the passive attribute in sysfs.
It's useful to display such trip points in /proc/acpi/thermal_zone.

.../TZ1/cooling_mode:<setting not supported>
.../TZ1/polling_frequency:polling frequency:       10 seconds
.../TZ1/state:state:                   ok
.../TZ1/temperature:temperature:             56 C
.../TZ1/trip_points:critical (S5):           110 C
.../TZ1/trip_points:passive:                 95 C: forced

Signed-off-by: Frans Pop <elendil@planet.nl>
Cc: Zhang Rui <rui.zhang@intel.com>
---

Now that I've got this set on my notebook, I also want to see that
it's set :-)

Cheers,
FJP

diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c
index 564ea14..c64cfa9 100644
--- a/drivers/acpi/thermal.c
+++ b/drivers/acpi/thermal.c
@@ -1050,6 +1050,10 @@ static int acpi_thermal_trip_seq_show(struct seq_file *seq, void *offset)
 				   acpi_device_bid(device));
 		}
 		seq_puts(seq, "\n");
+	} else if (tz->thermal_zone->forced_passive) {
+		seq_printf(seq,
+			   "passive:                 %i C: forced",
+			   tz->thermal_zone->forced_passive / 1000);
 	}
 
 	for (i = 0; i < ACPI_THERMAL_MAX_ACTIVE; i++) {

Re: [PATCH] acpi: thermal: display forced passive trip points in proc

[Frans Pop]

On Friday 21 August 2009, Frans Pop wrote:
> Users can force a passive trip point for a thermal zone that does not
> have _PSV defined in ACPI by setting the passive attribute in sysfs.
> It's useful to display such trip points in /proc/acpi/thermal_zone.
>
> .../TZ1/cooling_mode:<setting not supported>
> .../TZ1/polling_frequency:polling frequency:       10 seconds
> .../TZ1/state:state:                   ok
> .../TZ1/temperature:temperature:             56 C
> .../TZ1/trip_points:critical (S5):           110 C
> .../TZ1/trip_points:passive:                 95 C: forced

Hmm. Maybe the following would be clearer:
  .../TZ1/trip_points:passive (forced):        95 C

?

Re: [PATCH,v2] acpi: thermal: display forced passive trip points in proc

[Frans Pop]

Users can force a passive trip point for a thermal zone that does not
have _PSV defined in ACPI by setting the passive attribute in sysfs.
It's useful to display such trip points in /proc/acpi/thermal_zone.

.../TZ1/cooling_mode:<setting not supported>
.../TZ1/polling_frequency:polling frequency:       10 seconds
.../TZ1/state:state:                   ok
.../TZ1/temperature:temperature:             53 C
.../TZ1/trip_points:critical (S5):           110 C
.../TZ1/trip_points:passive (forced):        95 C

And if not set (passive is 0):
.../TZ1/trip_points:passive (forced):<not set>

Signed-off-by: Frans Pop <elendil@planet.nl>
Cc: Zhang Rui <rui.zhang@intel.com>
---

I noticed I forgot the linefeed and thought of a further improvement.

diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c
index 564ea14..7ff5789 100644
--- a/drivers/acpi/thermal.c
+++ b/drivers/acpi/thermal.c
@@ -1050,6 +1050,13 @@ static int acpi_thermal_trip_seq_show(struct 
seq_file *seq, void *offset)
 				   acpi_device_bid(device));
 		}
 		seq_puts(seq, "\n");
+	} else {
+		seq_printf(seq, "passive (forced):");
+		if (tz->thermal_zone->forced_passive)
+			seq_printf(seq, "        %i C\n",
+				   tz->thermal_zone->forced_passive / 1000);
+		else
+			seq_printf(seq, "<not set>\n");
 	}
 
 	for (i = 0; i < ACPI_THERMAL_MAX_ACTIVE; i++) {