From: Andrew Morton <akpm@linux-foundation.org>
To: Frans Pop <elendil@planet.nl>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
lenb@intel.com, rui.zhang@intel.com
Subject: Re: [PATCH 1/2] ACPI processor: force throttling state when BIOS returns incorrect value
Date: Wed, 26 Aug 2009 12:16:19 -0700 [thread overview]
Message-ID: <20090826121619.2bc7e72b.akpm@linux-foundation.org> (raw)
In-Reply-To: <200908171443.35622.elendil@planet.nl>
On Mon, 17 Aug 2009 14:43:34 +0200
Frans Pop <elendil@planet.nl> wrote:
> --- a/drivers/acpi/processor_throttling.c
> +++ b/drivers/acpi/processor_throttling.c
> @@ -62,7 +62,8 @@ struct throttling_tstate {
> #define THROTTLING_POSTCHANGE (2)
>
> static int acpi_processor_get_throttling(struct acpi_processor *pr);
> -int acpi_processor_set_throttling(struct acpi_processor *pr, int state);
> +int acpi_processor_set_throttling(struct acpi_processor *pr,
> + int state, bool force);
>
WARNING: externs should be avoided in .c files
#74: FILE: drivers/acpi/processor_throttling.c:65:
+int acpi_processor_set_throttling(struct acpi_processor *pr,
total: 0 errors, 1 warnings, 137 lines checked
checkpatch speaketh truth - there's already a declaration in
acpi/processor.h anyway.
I'll leave it alone though. Cleaning up acpi code isn't on the agenda
for today.
Please integrate checkpatch into your patch preparation tools. It
finds stuff.
next prev parent reply other threads:[~2009-08-26 19:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-17 12:43 [PATCH 1/2] ACPI processor: force throttling state when BIOS returns incorrect value Frans Pop
2009-08-17 12:45 ` [PATCH 2/2] ACPI processor: remove superfluous warning message Frans Pop
2009-08-19 18:58 ` [PATCH 1/2] ACPI processor: force throttling state when BIOS returns incorrect value Andrew Morton
2009-08-27 17:31 ` Len Brown
2009-08-27 18:28 ` Frans Pop
2009-08-26 19:16 ` Andrew Morton [this message]
2009-08-26 19:41 ` Frans Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090826121619.2bc7e72b.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=elendil@planet.nl \
--cc=lenb@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).