public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <jdelvare@suse.de>
To: linux-acpi@vger.kernel.org
Cc: Zhang Rui <rui.zhang@intel.com>, Len Brown <len.brown@intel.com>,
	Thomas Renninger <trenn@suse.de>
Subject: [PATCH] ACPI: Clarify resource conflict message
Date: Sun, 30 Aug 2009 15:46:22 +0200	[thread overview]
Message-ID: <200908301546.22827.jdelvare@suse.de> (raw)

The message "ACPI: Device needs an ACPI driver" is misleading. The
device _may_ need an ACPI driver, if the BIOS implemented an API for
the device in question (which, AFAIK, can't be checked.) If not, then
either the generic "thermal" ACPI driver may be used, or nothing can
be done (other than a white list, if we really want to get hardware
monitoring on some machines.)

I propose to reword the message to:

ACPI: Device may still be supported by an ACPI driver

which I think is more correct. Comments and suggestions welcome.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Zhang Rui <rui.zhang@intel.com>
Cc: Len Brown <len.brown@intel.com>
Cc: Thomas Renninger <trenn@suse.de>
---
 drivers/acpi/osl.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- linux-2.6.31-rc8.orig/drivers/acpi/osl.c	2009-08-28 19:48:58.000000000 +0200
+++ linux-2.6.31-rc8/drivers/acpi/osl.c	2009-08-30 10:10:51.000000000 +0200
@@ -1182,7 +1182,8 @@ int acpi_check_resource_conflict(struct
 			       res_list_elem->name,
 			       (long long) res_list_elem->start,
 			       (long long) res_list_elem->end);
-			printk(KERN_INFO "ACPI: Device needs an ACPI driver\n");
+			printk(KERN_INFO "ACPI: Device may still be supported"
+			       " by an ACPI driver\n");
 		}
 		if (acpi_enforce_resources == ENFORCE_RESOURCES_STRICT)
 			return -EBUSY;

-- 
Jean Delvare
Suse L3

             reply	other threads:[~2009-08-30 13:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-30 13:46 Jean Delvare [this message]
2009-08-30 21:10 ` [PATCH] ACPI: Clarify resource conflict message Alan Jenkins
2009-08-31 17:19   ` Len Brown
2009-09-07 13:36     ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200908301546.22827.jdelvare@suse.de \
    --to=jdelvare@suse.de \
    --cc=len.brown@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=trenn@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox