public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Matthew Garrett <mjg@redhat.com>
To: robert.moore@intel.com
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/3] Rework GPE handling
Date: Wed, 2 Sep 2009 19:10:14 +0100	[thread overview]
Message-ID: <20090902181014.GA10917@srcf.ucam.org> (raw)

The current GPE code attempts to define GPEs as either runtime (the 
default), wake or run/wake. These states are orthogonal to whether or 
not a GPE is actually enabled or not. Further, various additional flags 
are defined and set, but never used.

This architecture is additionally complicated by changing the type of a 
GPE causing it to be disabled, resulting in complex functions that then 
have to conditionally re-enable a GPE. It also makes it impossible to 
determine how many consumers a given GPE has, preventing us from 
being able to implement runtime power management for devices requiring 
GPEs for wakeup notification.

This patchset adds a new, simpler API and transitions the existing users 
over to it. It then removes the old code.

 drivers/acpi/acpica/acevents.h |    6 -
 drivers/acpi/acpica/aclocal.h  |    2 
 drivers/acpi/acpica/evgpe.c    |  150 ++++---------------------------------
 drivers/acpi/acpica/evgpeblk.c |  164 +----------------------------------------
 drivers/acpi/acpica/evxface.c  |   14 ---
 drivers/acpi/acpica/evxfevnt.c |  139 ++++++++++++++++++++++++++++++++--
 drivers/acpi/button.c          |   18 +++-
 drivers/acpi/ec.c              |    5 -
 drivers/acpi/wakeup.c          |   57 +++-----------
 include/acpi/acpixf.h          |    8 ++
 include/acpi/actypes.h         |   32 ++------
 11 files changed, 197 insertions(+), 398 deletions(-)

-- 
Matthew Garrett | mjg59@srcf.ucam.org

             reply	other threads:[~2009-09-02 18:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-02 18:10 Matthew Garrett [this message]
2009-09-02 18:12 ` [PATCH 1/3] ACPI: Add infrastructure for refcounting GPE consumers Matthew Garrett
2009-09-02 18:12   ` [PATCH 2/3] ACPI: Add support for new refcounted GPE API to drivers Matthew Garrett
2009-09-02 18:12     ` [PATCH 3/3] ACPI: Remove old GPE API and transition code entirely to new one Matthew Garrett
2009-09-02 20:37       ` Daniel Walker
2009-09-15 21:50       ` Rafael J. Wysocki
2009-09-15 21:30   ` [PATCH 1/3] ACPI: Add infrastructure for refcounting GPE consumers Rafael J. Wysocki
2009-09-17 21:19     ` Moore, Robert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090902181014.GA10917@srcf.ucam.org \
    --to=mjg@redhat.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robert.moore@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox