From: Matthew Garrett <mjg59@srcf.ucam.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: pm list <linux-pm@lists.linux-foundation.org>,
Linux PCI <linux-pci@vger.kernel.org>,
Len Brown <lenb@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Shaohua Li <shaohua.li@intel.com>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Subject: Re: [RFC][PATCH 3/4] PCI / ACPI PM: Platform support for PCI PME wake-up
Date: Sun, 13 Sep 2009 23:25:05 +0100 [thread overview]
Message-ID: <20090913222505.GC31175@srcf.ucam.org> (raw)
In-Reply-To: <200909132324.03340.rjw@sisk.pl>
On Sun, Sep 13, 2009 at 11:24:03PM +0200, Rafael J. Wysocki wrote:
> + } else if (!dev->wakeup.flags.run_wake) {
> + acpi_set_gpe_type(dev->wakeup.gpe_device,
> + dev->wakeup.gpe_number,
> + ACPI_GPE_TYPE_WAKE);
Is this going to work for cases where we have multiple devices attached
to the same GPE? The common one is EHCI, where both EHCI HCDs will be
one a single GPE. If we wake one, that'll then disable the GPE for the
other. Further wakeup events will then be lost.
> + if (device->wakeup.flags.valid)
> + acpi_install_notify_handler(device->handle, ACPI_SYSTEM_NOTIFY,
> + pci_acpi_device_wakeup,
> + &dev->dev);
> +
I think this will fail for the root bridge if acpiphp has already
grabbed it to check for hotplug events.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2009-09-13 22:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-13 21:20 [RFC][PATCH 0/4] PCI / ACPI PM: Run-time PM, PME handling and PCI bus type callbacks Rafael J. Wysocki
2009-09-13 21:20 ` [RFC][PATCH 1/4] PCI PM: Add function for checking PME status of devices Rafael J. Wysocki
2009-09-13 22:15 ` Matthew Garrett
2009-09-13 21:22 ` [RFC][PATCH 2/4] PCI PM: PCIe PME root port service driver (rev. 3) Rafael J. Wysocki
2009-09-13 21:24 ` [RFC][PATCH 3/4] PCI / ACPI PM: Platform support for PCI PME wake-up Rafael J. Wysocki
2009-09-13 22:25 ` Matthew Garrett [this message]
2009-09-13 22:53 ` Rafael J. Wysocki
2009-09-13 22:55 ` Matthew Garrett
2009-09-13 23:08 ` Rafael J. Wysocki
2009-09-21 0:26 ` Rafael J. Wysocki
2009-10-06 17:32 ` Jesse Barnes
2009-10-06 21:32 ` Rafael J. Wysocki
2009-09-13 21:25 ` [RFC][PATCH 4/4] PCI PM: Run-time callbacks for PCI bus type Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090913222505.GC31175@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=jbarnes@virtuousgeek.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=rjw@sisk.pl \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox