From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Herton Ronaldo Krzesinski <herton@mandriva.com.br>
Cc: linux-acpi@vger.kernel.org, Len Brown <len.brown@intel.com>,
Alan Jenkins <sourcejedi.lkml@googlemail.com>,
Corentin Chary <corentin.chary@gmail.com>
Subject: Re: [PATCH v4] topstar-laptop: add new driver for hotkeys support on Topstar N01
Date: Mon, 14 Sep 2009 09:30:14 -0600 [thread overview]
Message-ID: <200909140930.14874.bjorn.helgaas@hp.com> (raw)
In-Reply-To: <200909120155.45521.herton@mandriva.com.br>
On Friday 11 September 2009 10:55:45 pm Herton Ronaldo Krzesinski wrote:
> +static int acpi_topstar_remove(struct acpi_device *device, int type)
> +{
> + struct topstar_hkey *tps_hkey = acpi_driver_data(device);
> +
> + acpi_topstar_fncx_switch(device, false);
> +
> + input_unregister_device(tps_hkey->inputdev);
> + kfree(tps_hkey);
> + device->driver_data = NULL;
I think you should remove this "driver_data = NULL" assignment.
Clearing it in the driver helps cover up bugs like the one Alan
just fixed:
http://marc.info/?l=linux-acpi&m=125276975701005&w=2
Bjorn
prev parent reply other threads:[~2009-09-14 15:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-10 0:02 [PATCH v4] topstar-laptop: add new driver for hotkeys support on Topstar N01 Herton Ronaldo Krzesinski
2009-09-10 23:02 ` Bjorn Helgaas
2009-09-12 4:55 ` Herton Ronaldo Krzesinski
2009-09-14 15:01 ` Bjorn Helgaas
2009-09-14 15:30 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200909140930.14874.bjorn.helgaas@hp.com \
--to=bjorn.helgaas@hp.com \
--cc=corentin.chary@gmail.com \
--cc=herton@mandriva.com.br \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=sourcejedi.lkml@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox