From: Rusty Russell <rusty@rustcorp.com.au>
To: Dave Jones <davej@redhat.com>
Cc: akpm@linux-foundation.org, lenb@kernel.org,
linux-acpi@vger.kernel.org, efault@gmx.de, jaswinder@kernel.org,
len.brown@intel.com, mingo@elte.hu, tglx@linutronix.de,
venkatesh.pallipadi@intel.com, yakui.zhao@intel.com,
yanmin_zhang@linux.intel.com
Subject: Re: [patch 2/8] arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c: avoid cross-CPU interrupts by using smp_call_function_any()
Date: Tue, 22 Sep 2009 16:47:38 +0930 [thread overview]
Message-ID: <200909221647.40106.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20090918195953.GB7413@redhat.com>
On Sat, 19 Sep 2009 05:29:53 am Dave Jones wrote:
> I'm ok with this going in, but I still wonder if we could have done it
> all a lot easier, by making cpumask_any pick the current cpu if it was
> in the mask instead of introducing yet another variant to an already
> enormous api.
That was the initial proposal, but I'm uncomfortable with that, too. "any"
really implies "doesn't matter"; if we overload it to have a preference, it
becomes really hard to tell which ones really care and which ones don't.
Then refactoring becomes harder (performance regression when you alter code).
So yeah, not ideal, but this seemed like the minimal API extension.
Cheers,
Rusty.
prev parent reply other threads:[~2009-09-22 7:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-18 19:41 [patch 2/8] arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c: avoid cross-CPU interrupts by using smp_call_function_any() akpm
2009-09-18 19:59 ` Dave Jones
2009-09-18 20:11 ` Andrew Morton
2009-09-22 7:17 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200909221647.40106.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=akpm@linux-foundation.org \
--cc=davej@redhat.com \
--cc=efault@gmx.de \
--cc=jaswinder@kernel.org \
--cc=len.brown@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=venkatesh.pallipadi@intel.com \
--cc=yakui.zhao@intel.com \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox