From: Pavel Machek <pavel@ucw.cz>
To: Jonathan Cameron <jic23@cam.ac.uk>
Cc: Zhang Rui <rui.zhang@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-acpi <linux-acpi@vger.kernel.org>,
Jean Delvare <khali@linux-fr.org>,
"alan@linux.intel.com" <alan@linux.intel.com>,
Len Brown <lenb@kernel.org>,
"Cory T. Tusar" <ctusar@videon-central.com>,
"Trisal, Kalhan" <kalhan.trisal@intel.com>
Subject: Re: [RFC] [PATCH 1/2] introduce ALS sysfs class
Date: Wed, 23 Sep 2009 09:18:57 +0200 [thread overview]
Message-ID: <20090923071857.GC8565@elf.ucw.cz> (raw)
In-Reply-To: <4AB8C62F.5020605@cam.ac.uk>
On Tue 2009-09-22 13:42:23, Jonathan Cameron wrote:
> Zhang Rui wrote:
> > Hi, Jonathan,
> >
> > this is the refresh ALS sysfs class driver.
> > I just introduced one sysfs attribute "illuminance", because
> > I didn't catch the exact meaning of the others like "???infrared".
> > So it would be great if you can generate an incremental patch
> > to introduce the other optional attributes needed, and update
> > the documentation as well. :)
> Will do, though may just leave it out of first pass of drivers
> (as it may be controversial and it would be nice to get something
> in place before the arguments begin!)
>
> All looks nice and clean. The only real question is whether
> we want to standardize naming of devices under sysfs (like hwmon does)
> or allow the individual drivers to do the naming?
Allow the drivers to do the naming. Having useless name like "als0",
with als0/name telling me what the driver is is bad.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2009-09-23 7:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-22 3:39 [RFC] [PATCH 1/2] introduce ALS sysfs class Zhang Rui
2009-09-22 12:42 ` Jonathan Cameron
2009-09-23 7:18 ` Pavel Machek [this message]
2009-09-23 7:26 ` Corentin Chary
2009-10-15 15:54 ` Jonathan Cameron
2009-10-09 14:39 ` Jonathan Cameron
2009-10-10 1:43 ` Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090923071857.GC8565@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=alan@linux.intel.com \
--cc=ctusar@videon-central.com \
--cc=jic23@cam.ac.uk \
--cc=kalhan.trisal@intel.com \
--cc=khali@linux-fr.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox